[PATCH v2] USB: Improve "New device found" printout message

[PATCH v2] USB: Improve "New device found" printout message

[Martin Rys]

From c5b92273e0b7e2f095cab876603d37a1f4530175 Mon Sep 17 00:00:00 2001
From: Martin Rys <martin@archlinux.org>
Date: Sat, 29 Aug 2026 20:26:44 +0200
Subject: [PATCH v2] USB: Improve "New device found" printout message

Use a colon instead of a comma, like the debug message after this one does.

Do not print a space after `bcdDevice=` - this was introduced as the formatting was copied from `lsusb -v` printout, but lsusb output has preceding spaces, this message does not, so it ends up looking odd.

Previously the output ended up looking like `idProduct=a000, bcdDevice= 1.00` if the first hex character of bcdDevice was 0.

Signed-off-by: Martin Rys <martin@archlinux.org>
---
v1 -> v2: No code changes, only amended commit message and hopefully sending it proper now.

 drivers/usb/core/hub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 3345b3298daf..c382215a1177 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2411,7 +2411,7 @@ static void announce_device_ids(struct usb_device *udev)
 	u16 bcdDevice = le16_to_cpu(udev->descriptor.bcdDevice);

 	dev_info(&udev->dev,
-		"New USB device found, idVendor=%04x, idProduct=%04x, bcdDevice=%2x.%02x\n",
+		"New USB device found: idVendor=%04x, idProduct=%04x, bcdDevice=%x.%02x\n",
 		le16_to_cpu(udev->descriptor.idVendor),
 		le16_to_cpu(udev->descriptor.idProduct),
 		bcdDevice >> 8, bcdDevice & 0xff);
--
2.55.0

Re: [PATCH v2] USB: Improve "New device found" printout message

[Greg KH]

On Sat, Aug 29, 2026 at 08:38:04PM +0200, Martin Rys wrote:
> >From c5b92273e0b7e2f095cab876603d37a1f4530175 Mon Sep 17 00:00:00 2001
> From: Martin Rys <martin@archlinux.org>
> Date: Sat, 29 Aug 2026 20:26:44 +0200
> Subject: [PATCH v2] USB: Improve "New device found" printout message

Nit, why is this in the body of the email?

> 
> Use a colon instead of a comma, like the debug message after this one does.
> 
> Do not print a space after `bcdDevice=` - this was introduced as the formatting was copied from `lsusb -v` printout, but lsusb output has preceding spaces, this message does not, so it ends up looking odd.

Please wrap your changelog text at 72 columns.  I thought checkpatch.pl
would warn about this, did it not?

thanks,

greg k-h

Re: [PATCH v2] USB: Improve "New device found" printout message

[Martin Rys]

> Nit, why is this in the body of the email?

It's the raw output from `git format-patch -1 HEAD -v2`.

Other than by implication in the "canonical patch format" section, 
neither of these docs seem to have a mention to delete any of the 
4 lines that I could find:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
https://www.kernel.org/doc/html/latest/process/email-clients.html

I see that the first line is some compatibility start of message marker,
so I am guessing that's not needed in any case when using Thunderbird.

Not that it's important, but is it possible to keep the Date: in, 
to retain the commit message time?

> Please wrap your changelog text at 72 columns.  I thought checkpatch.pl
> would warn about this, did it not?
It indeed does - I wrongly assumed it only covers the actual code changes,
so I didn't think to run it after adding the commit message.

Will run it on any change from now on, and I'll resend the patch wrapped shortly.

Thank you,
Martin

Re: [PATCH v2] USB: Improve "New device found" printout message

[Greg KH]

On Sun, Aug 30, 2026 at 09:56:15AM +0200, Martin Rys wrote:
> > Nit, why is this in the body of the email?
> 
> It's the raw output from `git format-patch -1 HEAD -v2`.
> 
> Other than by implication in the "canonical patch format" section, 
> neither of these docs seem to have a mention to delete any of the 
> 4 lines that I could find:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> https://www.kernel.org/doc/html/latest/process/email-clients.html
> 
> I see that the first line is some compatibility start of message marker,
> so I am guessing that's not needed in any case when using Thunderbird.
> 
> Not that it's important, but is it possible to keep the Date: in, 
> to retain the commit message time?

Those headers are emulating a mail message, you don't have to include
them again in the body of the email.

The date will be when you send the email, not when the patch was made on
your local machine.  If you use something like git send-email or b4 to
send the patch, those headers are not included.  If you use thunderbird,
that's great, don't include them either, just like if you use a tool
like mutt (which I do for many patches), you don't include the headers.

thanks,

greg k-h