From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
ravitejax.veesam@intel.com
Subject: Re: [PATCH 08/15] xhci: dbc: serialize enabling and disabling dbc
Date: Mon, 15 Jun 2026 11:47:50 +0300 [thread overview]
Message-ID: <79a7df51-a2ac-4206-987a-83737e1d316f@linux.intel.com> (raw)
In-Reply-To: <9ce24ff5-efab-4089-92d7-709862d68e6d@intel.com>
On 6/15/26 09:11, Borah, Chaitanya Kumar wrote:
>
> Hello Mathias,
>
> On 6/3/2026 2:41 PM, Mathias Nyman wrote:
>> DbC can be enabled and disabled via sysfs, serialize those
>> with a mutex to make sure everything is done in the correct
>> order.
>>
>> remove xhci_do_dbc_stop() and integrate the register write and
>> dbc->state setting into xhci_do_stop()
>>
>
> This patch seems to cause a regression in our CI. [1]
>
> We could not revert the patch because of merge conflicts but resetting to the parent commit seems to heal the issue.
>
> Could you please check why the patch causes this regression and provide
> a fix if necessary?
Ah, I see, deadlock when enabling DbC via sysfs on runtime suspended xhci
Appears this is an issue mid series in intel-next,
The last patch that enabled runtime pm for DbC should also fix this issue.
The DbC runtime pm support patch was dropped last minute from the upstream series.
I'll send it as a RFT, can you check it solve the issue in your CI
Details of deadlock issue while mid series:
dbc_store() { // enable dbc via syfs
mutex_lock(&dbc->enable_mutex);
xhci_dbc_start(dbc);
pm_runtime_get_sync(dbc->dev);
xhci_dbc_resume()
mutex_lock(&dbc->enable_mutex);
Thanks
Mathias
next prev parent reply other threads:[~2026-06-15 8:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 9:11 [PATCH 00/15] xhci features for usb-next Mathias Nyman
2026-06-03 9:11 ` [PATCH 01/15] usb: xhci: fix typo in xhci_set_port_power() comment Mathias Nyman
2026-06-03 9:11 ` [PATCH 02/15] usb: xhci: remove legacy 'num_trbs_free' tracking Mathias Nyman
2026-06-03 9:11 ` [PATCH 03/15] usb: xhci: Simplify xhci_quiesce() Mathias Nyman
2026-06-03 9:11 ` [PATCH 04/15] usb: xhci: Remove skip_isoc_td() Mathias Nyman
2026-06-03 9:11 ` [PATCH 05/15] usb: xhci: Remove isochronous URB_SHORT_NOT_OK handling Mathias Nyman
2026-06-03 9:11 ` [PATCH 06/15] usb: xhci: Improve Soft Retries after short transfers Mathias Nyman
2026-06-03 9:11 ` [PATCH 07/15] xhci: dbc: Fix sysfs ABI Documentation for xhci dbc states Mathias Nyman
2026-06-03 9:11 ` [PATCH 08/15] xhci: dbc: serialize enabling and disabling dbc Mathias Nyman
2026-06-15 6:11 ` Borah, Chaitanya Kumar
2026-06-15 8:47 ` Mathias Nyman [this message]
2026-06-15 8:55 ` [RFT PATCH] xhci: dbc: support runtime suspend while DbC is in enabled state Mathias Nyman
2026-06-15 12:14 ` Borah, Chaitanya Kumar
2026-06-03 9:11 ` [PATCH 09/15] xhci: dbc: add helper to set and clear DbC DCE enable bit Mathias Nyman
2026-06-03 9:11 ` [PATCH 10/15] xhci: dbc: add timestamps to DbC state changes in a new helper Mathias Nyman
2026-06-03 9:11 ` [PATCH 11/15] xhci: dbc: detect and recover hung DbC during enumeraton Mathias Nyman
2026-06-03 9:11 ` [PATCH 12/15] xhci: Prevent queuing new commands if xhci is inaccessible Mathias Nyman
2026-06-03 9:11 ` [PATCH 13/15] usb: xhci: refactor DCBAA struct Mathias Nyman
2026-06-03 9:11 ` [PATCH 14/15] usb: xhci: allocate DCBAA based on host controller max slots Mathias Nyman
2026-06-03 9:11 ` [PATCH 15/15] usb: xhci: allocate internal DCBAA mirror dynamically Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a7df51-a2ac-4206-987a-83737e1d316f@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-usb@vger.kernel.org \
--cc=ravitejax.veesam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox