* Re: [PATCH] usb: rust: mark Device and Interface methods as inline
[not found] <20260616223614.16444-1-nico.antinori.7@gmail.com>
@ 2026-06-17 15:34 ` Danilo Krummrich
2026-06-17 15:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Danilo Krummrich @ 2026-06-17 15:34 UTC (permalink / raw)
To: Nicolás Antinori, Greg Kroah-Hartman
Cc: Miguel Ojeda, Alexandre Courbot, Alice Ryhl, Andreas Hindborg,
Benno Lossin, Björn Roy Baron, Boqun Feng, Daniel Almeida,
Gary Guo, Onur Özkan, Shuah Khan, Tamir Duberstein,
Trevor Gross, linux-kernel, rust-for-linux, linux-kernel-mentees,
linux-usb
(Cc: Greg, linux-usb)
Looks like the Rust USB code wasn't added to the USB MAINTAINERS entry.
On Wed Jun 17, 2026 at 12:36 AM CEST, Nicolás Antinori wrote:
> When building the kernel using llvm-19.1.7-rust-1.85.1-x86_64, the
> following symbols are generated:
>
> $ nm vmlinux | grep ' _R'.*usb.*Device | rustfilt
> ...
> ffffffff823f2490 T <kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::dec_ref
> ffffffff823f2470 T <kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::inc_ref
> ...
>
> $ nm vmlinux | grep ' _R'.*usb.*Interface | rustfilt
> ffffffff823f2450 T <kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::dec_ref
> ffffffff823f2430 T <kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::inc_ref
> ...
>
> However, these Rust symbols are trivial wrappers around the
> `usb_get_dev`, `usb_put_dev`, `usb_get_intf` and `usb_put_intf`
> functions. It doesn't make sense to go through a trivial wrapper
> for these functions.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1145
> Suggested-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Nicolás Antinori <nico.antinori.7@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: rust: mark Device and Interface methods as inline
2026-06-17 15:34 ` [PATCH] usb: rust: mark Device and Interface methods as inline Danilo Krummrich
@ 2026-06-17 15:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-06-17 15:39 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Nicolás Antinori, Miguel Ojeda, Alexandre Courbot,
Alice Ryhl, Andreas Hindborg, Benno Lossin, Björn Roy Baron,
Boqun Feng, Daniel Almeida, Gary Guo, Onur Özkan, Shuah Khan,
Tamir Duberstein, Trevor Gross, linux-kernel, rust-for-linux,
linux-kernel-mentees, linux-usb
On Wed, Jun 17, 2026 at 05:34:02PM +0200, Danilo Krummrich wrote:
> (Cc: Greg, linux-usb)
>
> Looks like the Rust USB code wasn't added to the USB MAINTAINERS entry.
Yeah, we should fix that. As it didn't actually work I wasn't too
worried about it yet :)
I'll knock up a patch later this week.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-17 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260616223614.16444-1-nico.antinori.7@gmail.com>
2026-06-17 15:34 ` [PATCH] usb: rust: mark Device and Interface methods as inline Danilo Krummrich
2026-06-17 15:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox