Re: [PATCH] usb: rust: mark Device and Interface methods as inline

Re: [PATCH] usb: rust: mark Device and Interface methods as inline

[Danilo Krummrich]

(Cc: Greg, linux-usb)

Looks like the Rust USB code wasn't added to the USB MAINTAINERS entry.

On Wed Jun 17, 2026 at 12:36 AM CEST, Nicolás Antinori wrote:
> When building the kernel using llvm-19.1.7-rust-1.85.1-x86_64, the
> following symbols are generated:
>
> $ nm vmlinux | grep ' _R'.*usb.*Device | rustfilt
> ...
> ffffffff823f2490 T <kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::dec_ref
> ffffffff823f2470 T <kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::inc_ref
> ...
>
> $ nm vmlinux | grep ' _R'.*usb.*Interface | rustfilt
> ffffffff823f2450 T <kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::dec_ref
> ffffffff823f2430 T <kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::inc_ref
> ...
>
> However, these Rust symbols are trivial wrappers around the
> `usb_get_dev`, `usb_put_dev`, `usb_get_intf` and `usb_put_intf`
> functions. It doesn't make sense to go through a trivial wrapper
> for these functions.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1145
> Suggested-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Nicolás Antinori <nico.antinori.7@gmail.com>

Re: [PATCH] usb: rust: mark Device and Interface methods as inline

[Greg Kroah-Hartman]

On Wed, Jun 17, 2026 at 05:34:02PM +0200, Danilo Krummrich wrote:
> (Cc: Greg, linux-usb)
> 
> Looks like the Rust USB code wasn't added to the USB MAINTAINERS entry.

Yeah, we should fix that.  As it didn't actually work I wasn't too
worried about it yet :)

I'll knock up a patch later this week.

thanks,

greg k-h