Linux USB
 help / color / mirror / Atom feed
* [PATCH v1] drivers/usb/core/driver: check return value of usb_set_interface()
@ 2022-09-09  4:42 Li Zhong
  2022-09-09  5:27 ` Greg KH
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Li Zhong @ 2022-09-09  4:42 UTC (permalink / raw)
  To: linux-kernel, linux-usb
  Cc: heghedus.razvan, evgreen, yuanjilin, stern, jj251510319013,
	gregkh, Li Zhong

Check return value of usb_set_interface() and report error if it fails.
Otherwise usb_set_interface() may fail without any warnings. 

This flaw was found using an experimental static analysis tool we are
developing. Report warnings when the function usb_set_interface() fails
can increase the dianosability.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
 drivers/usb/core/driver.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 7e7e119c253f..ee375b5eafe6 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1332,8 +1332,10 @@ static int usb_resume_interface(struct usb_device *udev,
 
 		/* Carry out a deferred switch to altsetting 0 */
 		if (intf->needs_altsetting0 && !intf->dev.power.is_prepared) {
-			usb_set_interface(udev, intf->altsetting[0].
-					desc.bInterfaceNumber, 0);
+			status = usb_set_interface(udev, intf->altsetting[0].desc.bInterfaceNumber, 0);
+			if (status < 0)
+				dev_err(intf->dev, "usb_set_interface error %d\n",
+							status);
 			intf->needs_altsetting0 = 0;
 		}
 		goto done;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-09 11:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-09  4:42 [PATCH v1] drivers/usb/core/driver: check return value of usb_set_interface() Li Zhong
2022-09-09  5:27 ` Greg KH
2022-09-09 10:12 ` kernel test robot
2022-09-09 10:21 ` Greg KH
2022-09-09 11:23 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox