[PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Chaoyi Chen]

From: Chaoyi Chen <chaoyi.chen@rock-chips.com>

When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
also needed for embedded platforms. Select it when available.

Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
Changes in v3:
- Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/
- Use the same "select" as v1 to make things simple. 

Changes in v2:
- Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
- Change "select" to "imply".
---

 drivers/usb/typec/altmodes/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
index 7867fa7c405d..b054c0b6a8d4 100644
--- a/drivers/usb/typec/altmodes/Kconfig
+++ b/drivers/usb/typec/altmodes/Kconfig
@@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
 config TYPEC_DP_ALTMODE
 	tristate "DisplayPort Alternate Mode driver"
 	depends on DRM
+	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
 	help
 	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
 	  displays and adapters to be attached to the USB Type-C
-- 
2.54.0

Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Heikki Krogerus]

On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
> also needed for embedded platforms. Select it when available.
> 
> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> ---
> Changes in v3:
> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/
> - Use the same "select" as v1 to make things simple. 
> 
> Changes in v2:
> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
> - Change "select" to "imply".
> ---
> 
>  drivers/usb/typec/altmodes/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
> index 7867fa7c405d..b054c0b6a8d4 100644
> --- a/drivers/usb/typec/altmodes/Kconfig
> +++ b/drivers/usb/typec/altmodes/Kconfig
> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
>  config TYPEC_DP_ALTMODE
>  	tristate "DisplayPort Alternate Mode driver"
>  	depends on DRM
> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF

Is there really no way of making this into a dependency?
Doesn't this, or something like it not work:

        depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE

Thanks,

>  	help
>  	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
>  	  displays and adapters to be attached to the USB Type-C
> -- 
> 2.54.0

-- 
heikki

Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Chaoyi Chen]

Hi Heikki,

On 7/13/2026 5:35 PM, Heikki Krogerus wrote:
> On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>>
>> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
>> also needed for embedded platforms. Select it when available.
>>
>> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>> ---
>> Changes in v3:
>> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/
>> - Use the same "select" as v1 to make things simple. 
>>
>> Changes in v2:
>> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
>> - Change "select" to "imply".
>> ---
>>
>>  drivers/usb/typec/altmodes/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
>> index 7867fa7c405d..b054c0b6a8d4 100644
>> --- a/drivers/usb/typec/altmodes/Kconfig
>> +++ b/drivers/usb/typec/altmodes/Kconfig
>> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
>>  config TYPEC_DP_ALTMODE
>>  	tristate "DisplayPort Alternate Mode driver"
>>  	depends on DRM
>> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> 
> Is there really no way of making this into a dependency?
> Doesn't this, or something like it not work:
> 
>         depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE
>

I think Xu originally wanted to select this item directly, since it
wasn't visible in the menu and there was nowhere to select it on some platforms.

> Thanks,
> 
>>  	help
>>  	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
>>  	  displays and adapters to be attached to the USB Type-C
>> -- 
>> 2.54.0
> 

-- 
Best, 
Chaoyi

Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Heikki Krogerus]

On Wed, Jul 15, 2026 at 09:19:24AM +0800, Chaoyi Chen wrote:
> Hi Heikki,
> 
> On 7/13/2026 5:35 PM, Heikki Krogerus wrote:
> > On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote:
> >> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> >>
> >> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
> >> also needed for embedded platforms. Select it when available.
> >>
> >> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
> >> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> >> ---
> >> Changes in v3:
> >> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/
> >> - Use the same "select" as v1 to make things simple. 
> >>
> >> Changes in v2:
> >> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/
> >> - Change "select" to "imply".
> >> ---
> >>
> >>  drivers/usb/typec/altmodes/Kconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
> >> index 7867fa7c405d..b054c0b6a8d4 100644
> >> --- a/drivers/usb/typec/altmodes/Kconfig
> >> +++ b/drivers/usb/typec/altmodes/Kconfig
> >> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
> >>  config TYPEC_DP_ALTMODE
> >>  	tristate "DisplayPort Alternate Mode driver"
> >>  	depends on DRM
> >> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> > 
> > Is there really no way of making this into a dependency?
> > Doesn't this, or something like it not work:
> > 
> >         depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE
> >
> 
> I think Xu originally wanted to select this item directly, since it
> wasn't visible in the menu and there was nowhere to select it on some platforms.

But now it is user selectable, no?

Thanks,

-- 
heikki