* [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE @ 2026-07-09 6:21 Chaoyi Chen 2026-07-13 9:35 ` Heikki Krogerus 0 siblings, 1 reply; 6+ messages in thread From: Chaoyi Chen @ 2026-07-09 6:21 UTC (permalink / raw) To: Heikki Krogerus, Greg Kroah-Hartman, Julian Braha, Xu Yang Cc: linux-usb, linux-kernel, Chaoyi Chen From: Chaoyi Chen <chaoyi.chen@rock-chips.com> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely also needed for embedded platforms. Select it when available. Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> --- Changes in v3: - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ - Use the same "select" as v1 to make things simple. Changes in v2: - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ - Change "select" to "imply". --- drivers/usb/typec/altmodes/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig index 7867fa7c405d..b054c0b6a8d4 100644 --- a/drivers/usb/typec/altmodes/Kconfig +++ b/drivers/usb/typec/altmodes/Kconfig @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" config TYPEC_DP_ALTMODE tristate "DisplayPort Alternate Mode driver" depends on DRM + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF help DisplayPort USB Type-C Alternate Mode allows DisplayPort displays and adapters to be attached to the USB Type-C -- 2.54.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE 2026-07-09 6:21 [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE Chaoyi Chen @ 2026-07-13 9:35 ` Heikki Krogerus 2026-07-15 1:19 ` Chaoyi Chen 0 siblings, 1 reply; 6+ messages in thread From: Heikki Krogerus @ 2026-07-13 9:35 UTC (permalink / raw) To: Chaoyi Chen Cc: Greg Kroah-Hartman, Julian Braha, Xu Yang, linux-usb, linux-kernel, Chaoyi Chen On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote: > From: Chaoyi Chen <chaoyi.chen@rock-chips.com> > > When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely > also needed for embedded platforms. Select it when available. > > Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> > Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> > --- > Changes in v3: > - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ > - Use the same "select" as v1 to make things simple. > > Changes in v2: > - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ > - Change "select" to "imply". > --- > > drivers/usb/typec/altmodes/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig > index 7867fa7c405d..b054c0b6a8d4 100644 > --- a/drivers/usb/typec/altmodes/Kconfig > +++ b/drivers/usb/typec/altmodes/Kconfig > @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" > config TYPEC_DP_ALTMODE > tristate "DisplayPort Alternate Mode driver" > depends on DRM > + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF Is there really no way of making this into a dependency? Doesn't this, or something like it not work: depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE Thanks, > help > DisplayPort USB Type-C Alternate Mode allows DisplayPort > displays and adapters to be attached to the USB Type-C > -- > 2.54.0 -- heikki ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE 2026-07-13 9:35 ` Heikki Krogerus @ 2026-07-15 1:19 ` Chaoyi Chen 2026-07-16 8:44 ` Heikki Krogerus 0 siblings, 1 reply; 6+ messages in thread From: Chaoyi Chen @ 2026-07-15 1:19 UTC (permalink / raw) To: Heikki Krogerus Cc: Greg Kroah-Hartman, Julian Braha, Xu Yang, linux-usb, linux-kernel Hi Heikki, On 7/13/2026 5:35 PM, Heikki Krogerus wrote: > On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote: >> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >> >> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely >> also needed for embedded platforms. Select it when available. >> >> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> >> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >> --- >> Changes in v3: >> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ >> - Use the same "select" as v1 to make things simple. >> >> Changes in v2: >> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ >> - Change "select" to "imply". >> --- >> >> drivers/usb/typec/altmodes/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig >> index 7867fa7c405d..b054c0b6a8d4 100644 >> --- a/drivers/usb/typec/altmodes/Kconfig >> +++ b/drivers/usb/typec/altmodes/Kconfig >> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" >> config TYPEC_DP_ALTMODE >> tristate "DisplayPort Alternate Mode driver" >> depends on DRM >> + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF > > Is there really no way of making this into a dependency? > Doesn't this, or something like it not work: > > depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE > I think Xu originally wanted to select this item directly, since it wasn't visible in the menu and there was nowhere to select it on some platforms. > Thanks, > >> help >> DisplayPort USB Type-C Alternate Mode allows DisplayPort >> displays and adapters to be attached to the USB Type-C >> -- >> 2.54.0 > -- Best, Chaoyi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE 2026-07-15 1:19 ` Chaoyi Chen @ 2026-07-16 8:44 ` Heikki Krogerus 2026-07-16 10:31 ` Chaoyi Chen 0 siblings, 1 reply; 6+ messages in thread From: Heikki Krogerus @ 2026-07-16 8:44 UTC (permalink / raw) To: Chaoyi Chen Cc: Greg Kroah-Hartman, Julian Braha, Xu Yang, linux-usb, linux-kernel On Wed, Jul 15, 2026 at 09:19:24AM +0800, Chaoyi Chen wrote: > Hi Heikki, > > On 7/13/2026 5:35 PM, Heikki Krogerus wrote: > > On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote: > >> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> > >> > >> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely > >> also needed for embedded platforms. Select it when available. > >> > >> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> > >> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> > >> --- > >> Changes in v3: > >> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ > >> - Use the same "select" as v1 to make things simple. > >> > >> Changes in v2: > >> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ > >> - Change "select" to "imply". > >> --- > >> > >> drivers/usb/typec/altmodes/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig > >> index 7867fa7c405d..b054c0b6a8d4 100644 > >> --- a/drivers/usb/typec/altmodes/Kconfig > >> +++ b/drivers/usb/typec/altmodes/Kconfig > >> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" > >> config TYPEC_DP_ALTMODE > >> tristate "DisplayPort Alternate Mode driver" > >> depends on DRM > >> + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF > > > > Is there really no way of making this into a dependency? > > Doesn't this, or something like it not work: > > > > depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE > > > > I think Xu originally wanted to select this item directly, since it > wasn't visible in the menu and there was nowhere to select it on some platforms. But now it is user selectable, no? Thanks, -- heikki ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE 2026-07-16 8:44 ` Heikki Krogerus @ 2026-07-16 10:31 ` Chaoyi Chen 2026-07-16 11:53 ` Heikki Krogerus 0 siblings, 1 reply; 6+ messages in thread From: Chaoyi Chen @ 2026-07-16 10:31 UTC (permalink / raw) To: Heikki Krogerus Cc: Greg Kroah-Hartman, Julian Braha, Xu Yang, linux-usb, linux-kernel On 7/16/2026 4:44 PM, Heikki Krogerus wrote: > On Wed, Jul 15, 2026 at 09:19:24AM +0800, Chaoyi Chen wrote: >> Hi Heikki, >> >> On 7/13/2026 5:35 PM, Heikki Krogerus wrote: >>> On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote: >>>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>> >>>> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely >>>> also needed for embedded platforms. Select it when available. >>>> >>>> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> >>>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>> --- >>>> Changes in v3: >>>> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ >>>> - Use the same "select" as v1 to make things simple. >>>> >>>> Changes in v2: >>>> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ >>>> - Change "select" to "imply". >>>> --- >>>> >>>> drivers/usb/typec/altmodes/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig >>>> index 7867fa7c405d..b054c0b6a8d4 100644 >>>> --- a/drivers/usb/typec/altmodes/Kconfig >>>> +++ b/drivers/usb/typec/altmodes/Kconfig >>>> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" >>>> config TYPEC_DP_ALTMODE >>>> tristate "DisplayPort Alternate Mode driver" >>>> depends on DRM >>>> + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF >>> >>> Is there really no way of making this into a dependency? >>> Doesn't this, or something like it not work: >>> >>> depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE >>> >> >> I think Xu originally wanted to select this item directly, since it >> wasn't visible in the menu and there was nowhere to select it on some platforms. > > But now it is user selectable, no? No, currently it needs to be explicitly selected in Kconfig, and it is not visible to the user. > > Thanks, > -- Best, Chaoyi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE 2026-07-16 10:31 ` Chaoyi Chen @ 2026-07-16 11:53 ` Heikki Krogerus 0 siblings, 0 replies; 6+ messages in thread From: Heikki Krogerus @ 2026-07-16 11:53 UTC (permalink / raw) To: Chaoyi Chen Cc: Greg Kroah-Hartman, Julian Braha, Xu Yang, linux-usb, linux-kernel On Thu, Jul 16, 2026 at 06:31:45PM +0800, Chaoyi Chen wrote: > On 7/16/2026 4:44 PM, Heikki Krogerus wrote: > > On Wed, Jul 15, 2026 at 09:19:24AM +0800, Chaoyi Chen wrote: > >> Hi Heikki, > >> > >> On 7/13/2026 5:35 PM, Heikki Krogerus wrote: > >>> On Thu, Jul 09, 2026 at 02:21:47PM +0800, Chaoyi Chen wrote: > >>>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> > >>>> > >>>> When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely > >>>> also needed for embedded platforms. Select it when available. > >>>> > >>>> Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com> > >>>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> > >>>> --- > >>>> Changes in v3: > >>>> - Link to v2: https://lore.kernel.org/all/20260705065832.184-1-kernel@airkyi.com/ > >>>> - Use the same "select" as v1 to make things simple. > >>>> > >>>> Changes in v2: > >>>> - Link to v1: https://lore.kernel.org/all/20260702022036.44-1-kernel@airkyi.com/ > >>>> - Change "select" to "imply". > >>>> --- > >>>> > >>>> drivers/usb/typec/altmodes/Kconfig | 1 + > >>>> 1 file changed, 1 insertion(+) > >>>> > >>>> diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig > >>>> index 7867fa7c405d..b054c0b6a8d4 100644 > >>>> --- a/drivers/usb/typec/altmodes/Kconfig > >>>> +++ b/drivers/usb/typec/altmodes/Kconfig > >>>> @@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers" > >>>> config TYPEC_DP_ALTMODE > >>>> tristate "DisplayPort Alternate Mode driver" > >>>> depends on DRM > >>>> + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF > >>> > >>> Is there really no way of making this into a dependency? > >>> Doesn't this, or something like it not work: > >>> > >>> depends on (DRM_AUX_HPD_BRIDGE && DRM_BRIDGE && OF) || !DRM_AUX_HPD_BRIDGE > >>> > >> > >> I think Xu originally wanted to select this item directly, since it > >> wasn't visible in the menu and there was nowhere to select it on some platforms. > > > > But now it is user selectable, no? > > No, currently it needs to be explicitly selected in Kconfig, > and it is not visible to the user. Okay, yet another Kconfig option with dependencies that's not user selectable. Meaning, everything that selects that option has to carry the same dependencies, and hope that if those dependencies ever change they are updated everywhere. :( I still don't like this at all, but let's go with it for now. Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Thanks, -- heikki ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-16 11:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-09 6:21 [PATCH v3] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE Chaoyi Chen 2026-07-13 9:35 ` Heikki Krogerus 2026-07-15 1:19 ` Chaoyi Chen 2026-07-16 8:44 ` Heikki Krogerus 2026-07-16 10:31 ` Chaoyi Chen 2026-07-16 11:53 ` Heikki Krogerus
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox