Linux USB
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Badhri Jagan Sridharan <badhri@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH 4/8] usb: typec: fusb302: switch to devm_pm_set_wake_irq
Date: Tue, 17 Nov 2026 14:20:57 +0100	[thread overview]
Message-ID: <avxUubGaIXH2kIqk@black.igk.intel.com> (raw)
In-Reply-To: <20261113-fusb302-probe-cleanup-v1-4-e5c65a8c58c8@collabora.com>

On Fri, Nov 13, 2026 at 05:42:40PM +0100, Sebastian Reichel wrote:
> Use the modern device managed wake IRQ helper provided by the PM layer
> instead of directly calling the interrupt wake enable/disable functions.
> 
> This results in the wake capability only being enabled once system suspend
> is entered as its not supposed to be set while the system is running
> normally. Also it now properly reacts to device_may_wakeup().
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index a7a1dce6cf86..8b83414c5819 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -19,6 +19,7 @@
>  #include <linux/mutex.h>
>  #include <linux/of.h>
>  #include <linux/pinctrl/consumer.h>
> +#include <linux/pm_wakeirq.h>
>  #include <linux/proc_fs.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/sched/clock.h>
> @@ -1804,16 +1805,11 @@ static int fusb302_probe(struct i2c_client *client)
>  	if (ret)
>  		return ret;
>  
> -	enable_irq_wake(chip->gpio_int_n_irq);
> -
> -	return ret;
> -}
> -
> -static void fusb302_remove(struct i2c_client *client)
> -{
> -	struct fusb302_chip *chip = i2c_get_clientdata(client);
> +	ret = devm_device_init_wakeup(chip->dev);
> +	if (ret)
> +		return ret;
>  
> -	disable_irq_wake(chip->gpio_int_n_irq);
> +	return devm_pm_set_wake_irq(chip->dev, chip->gpio_int_n_irq);
>  }
>  
>  static int fusb302_pm_suspend(struct device *dev)
> @@ -1870,7 +1866,6 @@ static struct i2c_driver fusb302_driver = {
>  		   .of_match_table = of_match_ptr(fusb302_dt_match),
>  		   },
>  	.probe = fusb302_probe,
> -	.remove = fusb302_remove,
>  	.id_table = fusb302_i2c_device_id,
>  };
>  module_i2c_driver(fusb302_driver);
> 
> -- 
> 2.53.0
> 

-- 
heikki

  parent reply	other threads:[~2026-11-17 13:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 16:42 [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Sebastian Reichel
2026-11-13 16:42 ` [PATCH 1/8] usb: typec: tcpm: allocate pd_list entries non device managed Sebastian Reichel
2026-11-13 16:55   ` sashiko-bot
2026-11-13 16:42 ` [PATCH 2/8] usb: typec: tcpm: add device managed port registration Sebastian Reichel
2026-11-13 17:06   ` sashiko-bot
2026-11-13 16:42 ` [PATCH 3/8] usb: typec: fusb302: Switch to device managed resources Sebastian Reichel
2026-11-13 17:21   ` sashiko-bot
2026-11-13 16:42 ` [PATCH 4/8] usb: typec: fusb302: switch to devm_pm_set_wake_irq Sebastian Reichel
2026-11-13 17:34   ` sashiko-bot
2026-11-17 13:20   ` Heikki Krogerus [this message]
2026-11-13 16:42 ` [PATCH 5/8] usb: typec: fusb302: rename init_gpio into fusb302_init_irq Sebastian Reichel
2026-11-13 17:35   ` sashiko-bot
2026-11-17 13:23   ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 6/8] usb: typec: fusb302: move gpio_int_n into function local scope Sebastian Reichel
2026-11-13 17:36   ` sashiko-bot
2026-11-17 13:24   ` Heikki Krogerus
2026-11-17 13:37     ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 7/8] usb: typec: fusb302: rework gpio_int_n_irq handling Sebastian Reichel
2026-11-13 17:41   ` sashiko-bot
2026-11-17 13:35   ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 8/8] usb: typec: fusb302: drop custom gpio interrupt logic Sebastian Reichel
2026-11-13 17:51   ` sashiko-bot
2026-11-16  8:32 ` [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Chaoyi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxUubGaIXH2kIqk@black.igk.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=badhri@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox