* [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot
@ 2025-02-03 6:08 Dominique Martinet
2025-02-03 6:20 ` Christophe JAILLET
2025-02-03 6:22 ` Christophe JAILLET
0 siblings, 2 replies; 3+ messages in thread
From: Dominique Martinet @ 2025-02-03 6:08 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Dominique Martinet
Use dev_err_probe to silence EPROBE_DEFER error on boot:
[ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
drivers/usb/misc/usb251xb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub)
if (np && usb_data) {
err = usb251xb_get_ofdata(hub, usb_data);
if (err) {
- dev_err(dev, "failed to get ofdata: %d\n", err);
- return err;
+ return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err);
}
}
---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250203-defer_usb1-254070d18cc9
Best regards,
--
Dominique Martinet <dominique.martinet@atmark-techno.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot
2025-02-03 6:08 [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
@ 2025-02-03 6:20 ` Christophe JAILLET
2025-02-03 6:22 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-02-03 6:20 UTC (permalink / raw)
To: Dominique Martinet, Richard Leitner, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel
Le 03/02/2025 à 07:08, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot:
> [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
>
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> drivers/usb/misc/usb251xb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub)
> if (np && usb_data) {
> err = usb251xb_get_ofdata(hub, usb_data);
> if (err) {
> - dev_err(dev, "failed to get ofdata: %d\n", err);
> - return err;
> + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err);
: %d\n", err should be removed now.
The error code will already be added in the message in a human readable way.
CJ
> }
> }
>
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb1-254070d18cc9
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot
2025-02-03 6:08 [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 6:20 ` Christophe JAILLET
@ 2025-02-03 6:22 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2025-02-03 6:22 UTC (permalink / raw)
To: Dominique Martinet, Richard Leitner, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel
Le 03/02/2025 à 07:08, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot:
> [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517
>
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
> drivers/usb/misc/usb251xb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub)
> if (np && usb_data) {
> err = usb251xb_get_ofdata(hub, usb_data);
> if (err) {
> - dev_err(dev, "failed to get ofdata: %d\n", err);
> - return err;
> + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err);
> }
extra { } can also be removed now that there is only 1 line left.
CJ
> }
>
>
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb1-254070d18cc9
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-03 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 6:08 [PATCH] usb: usb251xb: silence EPROBE_DEFER error on boot Dominique Martinet
2025-02-03 6:20 ` Christophe JAILLET
2025-02-03 6:22 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox