Re: [PATCH net-next v7 02/10] r8152: add new init writes for RTL8156/8156B/8157/8159

[sashiko-bot@kernel.org]

> Bring the per-generation init functions in line with the vendor init
> sequence by adding writes the shared r8156_init() never performed.
> 
> - Clear PREBOOT_OPTION and RMT_WAKE_EN in r8156_init() and
>   r8157_init().
> 
> - Add r8156b_u2phy_backup() for RTL8156B (VER_12/13/15).
> 
> - Clear AUTO_SPEEDUP in r8157_init().
> 
> - Disable interrupt mitigation (0xcf04) in r8157_init().
> 
> - Clear the Warm RST / Bus RST event flag (0xcd06 BIT(11)) in
>   r8157_init().
> 
> - Clear the FW u1u2 patch option (0xb9a6 BIT(0)) and enable the u3phy
>   patch backup (0xb9a2) for RTL8159 (VER_17) only.
> 
> - Clear RX_END_TRANSFER_EN (0xd406 BIT(11)) for RTL8157 (VER_16), too.
>   While it is set, incoming packets are buffered in the RX FIFO and
>   Bulk-in transfers are suspended. The bit is zero by default and
>   isn't used now. Clear it unconditionally for safety.
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014081904.6491-1-nic_swsd@realtek.com?part=2