Re: [PATCH net-next v7 04/10] r8152: split rtl8156_enable/up/down into per-generation functions

[sashiko-bot@kernel.org]

> rtl8156_enable(), rtl8156_up() and rtl8156_down() had accumulated
> tp->version range checks to cover RTL8156, RTL8156B, and
> RTL8157/RTL8159, including an early bail-out in rtl8156_enable()
> that skipped most of the function body for RTL8157/RTL8159. The
> result hides which settings belong to which chip, so chip-specific
> register differences cannot be reviewed, and cannot be added without
> touching the other families.
> 
> Give each generation its own ops callback: rtl8156_enable() for
> VER_10/11/12/13/15, and rtl8157_enable()/rtl8157_up()/rtl8157_down()
> for VER_16/17. rtl8156_up()/rtl8156_down() keep serving RTL8156 and
> RTL8156B (VER_10/11/12/13/15).
> 
> RTL8156/8156B/8157/8159 share most of the up/down sequence, so move
> it into common helpers, as RTL8152B/8153 do with exit_oob/enter_oob.
> 
> Each extracted function reproduces what its chips already did, with
> the guards that were true for them inlined and the ones that were
> false dropped as unreachable.
> 
> No functional change intended.
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014081904.6491-1-nic_swsd@realtek.com?part=4