Re: [PATCH net-next v7 07/10] r8152: add rtl8157_unload and rtl8157_change_mtu

[sashiko-bot@kernel.org]

> RTL8157 and RTL8159 used rtl8153_unload() and rtl8156_change_mtu(),
> which program power-cut and MTPS the way earlier chips require. Per
> the datasheet, RTL8157/RTL8159 need r8157_power_cut_en() (already
> used by r8157_init()) instead of r8153_power_cut_en(),
> and an MTPS scaled from the configured MTU (10K-16K, max_pkt_size /
> 64 capped at 0xff) instead of a fixed MTPS_JUMBO.
> 
> Add rtl8157_unload(), used only by RTL8157/RTL8159: calls
> r8157_power_cut_en(tp, false), then the Interrupt Mitigation disable
> that rtl8153_unload() used to gate on "tp->version >= RTL_VER_16"
> unconditionally, since this function now only runs for those
> versions.
> 
> Add rtl8157_change_mtu(), also RTL8157/RTL8159-only, and wire it up
> via ops->change_mtu in place of rtl8156_change_mtu().
> 
> Fixes: fd3c7d080df5 ("r8152: Add support for the RTL8157 hardware")
> Fixes: ad2a55b63b41 ("r8152: Add support for the RTL8159 chip")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014081904.6491-1-nic_swsd@realtek.com?part=7