Linux USB
 help / color / mirror / Atom feed
* [PATCH] usb: xhci: pci: do not perform Soft Retry on AMD 500 series chipset host
@ 2026-11-17 19:33 Riley Wagner
  2026-11-17 19:35 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Riley Wagner @ 2026-11-17 19:33 UTC (permalink / raw)
  To: mathias.nyman, linux-usb; +Cc: gregkh, Riley Wagner, stable

Full-speed HID devices hot-plugged into a root port of the AMD 500
series chipset xHCI host (1022:43ee) enumerate and bind, but never
deliver any input. The device then resets itself after ~10 seconds,
re-enumerates, and the cycle repeats. Devices present at boot are not
affected.

With xhci_hcd dynamic debug enabled, the first poll of the interrupt IN
endpoint fails with a transaction error, the driver performs a Soft
Retry, and the endpoint never completes another transfer:

  [ 6658.313453] xhci_hcd 0000:02:00.0: Successful Endpoint Configure command
  [ 6658.352348] input: ELECOM TrackBall Mouse HUGE TrackBall as ...
  [ 6659.424165] xhci_hcd 0000:02:00.0: Transfer error for slot 29 ep 2 on endpoint
  [ 6659.424170] xhci_hcd 0000:02:00.0: Soft-reset ep 2, slot 29
  [ 6659.424290] xhci_hcd 0000:02:00.0: Ignoring reset ep completion code of 1
  [ 6667.989369] usb 1-9: USB disconnect, device number 30

usbmon shows the interrupt URB submitted at enumeration and only given
back by the disconnect, 9.6 seconds later:

  2562187476 S Ii:1:030:1 -115:1 8 <
  2571824873 C Ii:1:030:1 -108:1 0

No further transfer events or errors are reported for the endpoint after
the soft reset completes and the doorbell is rung, so the TD is never
retried or failed.

This matches commit a4a251f8c235 ("usb: xhci: do not perform Soft Retry
for some xHCI hosts"), which disabled Soft Retry on the AMD Promontory A
hosts (43b9, 43bb) for the same class of failure. Booting with
xhci_hcd.quirks=0x10000000000 (XHCI_NO_SOFT_RETRY) makes the device work
reliably after hot-plug on the chipset root ports tested (1-3, 1-9); the
same device also works after hot-plug on the CPU's xHCI host (1022:149c)
without the quirk.

Tested on an ASUS ROG STRIX B550-F GAMING (BIOS 3621) with an ELECOM
HUGE trackball (056e:010c) and a PFU HHKB Professional HYBRID Type-S
(04fe:0021), on 7.3.4 with commit 6895dbdc19d9 ("xhci: give back TDs
and clean up ep0 after disconnect") applied. The trackball showed the
same behaviour on 7.2.x.

Add the AMD 500 series chipset xHCI to the hosts that do not perform
Soft Retry.

Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=202541
Cc: stable@vger.kernel.org
Signed-off-by: Riley Wagner <riwiwa00@gmail.com>
---
 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -88,6 +88,7 @@
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_3			0x43ba
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_2			0x43bb
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_1			0x43bc
+#define PCI_DEVICE_ID_AMD_500_SERIES_XHCI		0x43ee
 
 #define PCI_DEVICE_ID_ATI_NAVI10_7316_XHCI		0x7316
 
@@ -493,7 +494,8 @@
 
 	if (pdev->vendor == PCI_VENDOR_ID_AMD &&
 	    (pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_2 ||
-	     pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4))
+	     pdev->device == PCI_DEVICE_ID_AMD_PROMONTORYA_4 ||
+	     pdev->device == PCI_DEVICE_ID_AMD_500_SERIES_XHCI))
 		xhci->quirks |= XHCI_NO_SOFT_RETRY;
 
 	if (pdev->vendor == PCI_VENDOR_ID_ZHAOXIN) {
-- 
2.56.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17 19:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 19:33 [PATCH] usb: xhci: pci: do not perform Soft Retry on AMD 500 series chipset host Riley Wagner
2026-11-17 19:35 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox