* [PATCH 01/37] mei: wd: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 02/37] watchdog: wm8350: " Pratyush Anand
` (36 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Tomas Winkler
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/misc/mei/wd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/mei/wd.c b/drivers/misc/mei/wd.c
index 2bc0f5089f82..b346638833b0 100644
--- a/drivers/misc/mei/wd.c
+++ b/drivers/misc/mei/wd.c
@@ -364,6 +364,7 @@ int mei_watchdog_register(struct mei_device *dev)
int ret;
+ amt_wd_dev.parent = dev->dev;
/* unlock to perserve correct locking order */
mutex_unlock(&dev->device_lock);
ret = watchdog_register_device(&amt_wd_dev);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 02/37] watchdog: wm8350: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
2015-08-18 4:47 ` [PATCH 01/37] mei: wd: Fix parent of watchdog_device Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 03/37] watchdog: wm831x: " Pratyush Anand
` (35 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Wolfson Microelectronics
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Wolfson Microelectronics <linux@wolfsonmicro.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/wm8350_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/wm8350_wdt.c b/drivers/watchdog/wm8350_wdt.c
index 34d272ada23d..4ab4b8347d45 100644
--- a/drivers/watchdog/wm8350_wdt.c
+++ b/drivers/watchdog/wm8350_wdt.c
@@ -151,6 +151,7 @@ static int wm8350_wdt_probe(struct platform_device *pdev)
watchdog_set_nowayout(&wm8350_wdt, nowayout);
watchdog_set_drvdata(&wm8350_wdt, wm8350);
+ wm8350_wdt.parent = &pdev->dev;
/* Default to 4s timeout */
wm8350_wdt_set_timeout(&wm8350_wdt, 4);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 03/37] watchdog: wm831x: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
2015-08-18 4:47 ` [PATCH 01/37] mei: wd: Fix parent of watchdog_device Pratyush Anand
2015-08-18 4:47 ` [PATCH 02/37] watchdog: wm8350: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 04/37] watchdog: via: " Pratyush Anand
` (34 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Wolfson Microelectronics
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Wolfson Microelectronics <linux@wolfsonmicro.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/wm831x_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/wm831x_wdt.c b/drivers/watchdog/wm831x_wdt.c
index 2fa17e746ff6..8d1184aee932 100644
--- a/drivers/watchdog/wm831x_wdt.c
+++ b/drivers/watchdog/wm831x_wdt.c
@@ -215,6 +215,7 @@ static int wm831x_wdt_probe(struct platform_device *pdev)
wm831x_wdt->info = &wm831x_wdt_info;
wm831x_wdt->ops = &wm831x_wdt_ops;
+ wm831x_wdt->parent = &pdev->dev;
watchdog_set_nowayout(wm831x_wdt, nowayout);
watchdog_set_drvdata(wm831x_wdt, driver_data);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 04/37] watchdog: via: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (2 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 03/37] watchdog: wm831x: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 05/37] watchdog: ux500: " Pratyush Anand
` (33 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Marc Vertes
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Marc Vertes <marc.vertes@sigfox.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/via_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
index 56369c4f1961..5f9cbc37520d 100644
--- a/drivers/watchdog/via_wdt.c
+++ b/drivers/watchdog/via_wdt.c
@@ -206,6 +206,7 @@ static int wdt_probe(struct pci_dev *pdev,
timeout = WDT_TIMEOUT;
wdt_dev.timeout = timeout;
+ wdt_dev.parent = &pdev->dev;
watchdog_set_nowayout(&wdt_dev, nowayout);
if (readl(wdt_mem) & VIA_WDT_FIRED)
wdt_dev.bootstatus |= WDIOF_CARDRESET;
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 05/37] watchdog: ux500: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (3 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 04/37] watchdog: via: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 06/37] watchdog: txx9wdt: " Pratyush Anand
` (32 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog
Cc: dyoung, dzickus, Pratyush Anand, Mathieu Poirier, Jonas Aaberg
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Mathieu Poirier <mathieu.poirier@linaro.org>
cc: Jonas Aaberg <jonas.aberg@stericsson.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/ux500_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/ux500_wdt.c b/drivers/watchdog/ux500_wdt.c
index 9de09ab00838..37c084353cce 100644
--- a/drivers/watchdog/ux500_wdt.c
+++ b/drivers/watchdog/ux500_wdt.c
@@ -96,6 +96,7 @@ static int ux500_wdt_probe(struct platform_device *pdev)
ux500_wdt.max_timeout = WATCHDOG_MAX28;
}
+ ux500_wdt.parent = &pdev->dev;
watchdog_set_nowayout(&ux500_wdt, nowayout);
/* disable auto off on sleep */
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 06/37] watchdog: txx9wdt: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (4 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 05/37] watchdog: ux500: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 07/37] watchdog: twl4030: " Pratyush Anand
` (31 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Atsushi Nemoto
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/txx9wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/txx9wdt.c b/drivers/watchdog/txx9wdt.c
index 7f615933d31a..c4fa6b55c53d 100644
--- a/drivers/watchdog/txx9wdt.c
+++ b/drivers/watchdog/txx9wdt.c
@@ -131,6 +131,7 @@ static int __init txx9wdt_probe(struct platform_device *dev)
txx9wdt.timeout = timeout;
txx9wdt.min_timeout = 1;
txx9wdt.max_timeout = WD_MAX_TIMEOUT;
+ txx9wdt.parent = &pdev->dev;
watchdog_set_nowayout(&txx9wdt, nowayout);
ret = watchdog_register_device(&txx9wdt);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 07/37] watchdog: twl4030: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (5 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 06/37] watchdog: txx9wdt: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 08/37] watchdog: tegra: " Pratyush Anand
` (30 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Timo Kokkonen
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Timo Kokkonen <timo.t.kokkonen@nokia.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/twl4030_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
index 2c1db6fa9a27..9bf3cc0f3961 100644
--- a/drivers/watchdog/twl4030_wdt.c
+++ b/drivers/watchdog/twl4030_wdt.c
@@ -83,6 +83,7 @@ static int twl4030_wdt_probe(struct platform_device *pdev)
wdt->timeout = 30;
wdt->min_timeout = 1;
wdt->max_timeout = 30;
+ wdt->parent = &pdev->dev;
watchdog_set_nowayout(wdt, nowayout);
platform_set_drvdata(pdev, wdt);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 08/37] watchdog: tegra: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (6 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 07/37] watchdog: twl4030: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 09/37] watchdog: stmp3xxx_rtc: " Pratyush Anand
` (29 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, linux-tegra
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: linux-tegra@vger.kernel.org
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/tegra_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
index 30451ea46902..7f97cdd53f29 100644
--- a/drivers/watchdog/tegra_wdt.c
+++ b/drivers/watchdog/tegra_wdt.c
@@ -218,6 +218,7 @@ static int tegra_wdt_probe(struct platform_device *pdev)
wdd->ops = &tegra_wdt_ops;
wdd->min_timeout = MIN_WDT_TIMEOUT;
wdd->max_timeout = MAX_WDT_TIMEOUT;
+ wdd->parent = &pdev->dev;
watchdog_set_drvdata(wdd, wdt);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 09/37] watchdog: stmp3xxx_rtc: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (7 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 08/37] watchdog: tegra: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 10/37] watchdog: st_lpc: " Pratyush Anand
` (28 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Wolfram Sang
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Wolfram Sang <kernel@pengutronix.de>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/stmp3xxx_rtc_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/stmp3xxx_rtc_wdt.c b/drivers/watchdog/stmp3xxx_rtc_wdt.c
index e7f0d5b60d3d..3ee6128a540e 100644
--- a/drivers/watchdog/stmp3xxx_rtc_wdt.c
+++ b/drivers/watchdog/stmp3xxx_rtc_wdt.c
@@ -76,6 +76,7 @@ static int stmp3xxx_wdt_probe(struct platform_device *pdev)
watchdog_set_drvdata(&stmp3xxx_wdd, &pdev->dev);
stmp3xxx_wdd.timeout = clamp_t(unsigned, heartbeat, 1, STMP3XXX_MAX_TIMEOUT);
+ stmp3xxx_wdd.parent = &pdev->dev;
ret = watchdog_register_device(&stmp3xxx_wdd);
if (ret < 0) {
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 10/37] watchdog: st_lpc: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (8 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 09/37] watchdog: stmp3xxx_rtc: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 6:38 ` Lee Jones
2015-08-18 4:47 ` [PATCH 11/37] watchdog: sp805: " Pratyush Anand
` (27 subsequent siblings)
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, David Paris, Lee Jones
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: David Paris <david.paris@st.com>
cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/st_lpc_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
index 6785afdc0fca..14e9badf2bfa 100644
--- a/drivers/watchdog/st_lpc_wdt.c
+++ b/drivers/watchdog/st_lpc_wdt.c
@@ -241,6 +241,7 @@ static int st_wdog_probe(struct platform_device *pdev)
return -EINVAL;
}
st_wdog_dev.max_timeout = 0xFFFFFFFF / st_wdog->clkrate;
+ st_wdog_dev.parent = &pdev->dev;
ret = clk_prepare_enable(clk);
if (ret) {
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 10/37] watchdog: st_lpc: Fix parent of watchdog_device
2015-08-18 4:47 ` [PATCH 10/37] watchdog: st_lpc: " Pratyush Anand
@ 2015-08-18 6:38 ` Lee Jones
0 siblings, 0 replies; 47+ messages in thread
From: Lee Jones @ 2015-08-18 6:38 UTC (permalink / raw)
To: Pratyush Anand; +Cc: linux-watchdog, dyoung, dzickus, David Paris, kernel
On Tue, 18 Aug 2015, Pratyush Anand wrote:
> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: David Paris <david.paris@st.com>
> cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> drivers/watchdog/st_lpc_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
[Cc'ing the ST list, so they can have their say]
Looks reasonable. At least, it's what most of the other drivers do.
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
> index 6785afdc0fca..14e9badf2bfa 100644
> --- a/drivers/watchdog/st_lpc_wdt.c
> +++ b/drivers/watchdog/st_lpc_wdt.c
> @@ -241,6 +241,7 @@ static int st_wdog_probe(struct platform_device *pdev)
> return -EINVAL;
> }
> st_wdog_dev.max_timeout = 0xFFFFFFFF / st_wdog->clkrate;
> + st_wdog_dev.parent = &pdev->dev;
>
> ret = clk_prepare_enable(clk);
> if (ret) {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 11/37] watchdog: sp805: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (9 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 10/37] watchdog: st_lpc: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 6:41 ` Viresh Kumar
2015-08-18 4:47 ` [PATCH 12/37] watchdog: sirfsoc: " Pratyush Anand
` (26 subsequent siblings)
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Viresh Kumar
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Viresh Kumar <vireshk@kernel.org>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/sp805_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
index 4e7fec36f5c3..01d816251302 100644
--- a/drivers/watchdog/sp805_wdt.c
+++ b/drivers/watchdog/sp805_wdt.c
@@ -226,6 +226,7 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
wdt->adev = adev;
wdt->wdd.info = &wdt_info;
wdt->wdd.ops = &wdt_ops;
+ wdt->wdd.parent = &adev->dev;
spin_lock_init(&wdt->lock);
watchdog_set_nowayout(&wdt->wdd, nowayout);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 11/37] watchdog: sp805: Fix parent of watchdog_device
2015-08-18 4:47 ` [PATCH 11/37] watchdog: sp805: " Pratyush Anand
@ 2015-08-18 6:41 ` Viresh Kumar
0 siblings, 0 replies; 47+ messages in thread
From: Viresh Kumar @ 2015-08-18 6:41 UTC (permalink / raw)
To: Pratyush Anand; +Cc: linux-watchdog, dyoung, dzickus, Viresh Kumar
On 18-08-15, 10:17, Pratyush Anand wrote:
> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: Viresh Kumar <vireshk@kernel.org>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> drivers/watchdog/sp805_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index 4e7fec36f5c3..01d816251302 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -226,6 +226,7 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
> wdt->adev = adev;
> wdt->wdd.info = &wdt_info;
> wdt->wdd.ops = &wdt_ops;
> + wdt->wdd.parent = &adev->dev;
>
> spin_lock_init(&wdt->lock);
> watchdog_set_nowayout(&wdt->wdd, nowayout);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 12/37] watchdog: sirfsoc: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (10 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 11/37] watchdog: sp805: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 13/37] watchdog: sh: " Pratyush Anand
` (25 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Barry Song
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Barry Song <baohua@kernel.org>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/sirfsoc_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/sirfsoc_wdt.c b/drivers/watchdog/sirfsoc_wdt.c
index 42fa5c0c518a..d0578ab2e636 100644
--- a/drivers/watchdog/sirfsoc_wdt.c
+++ b/drivers/watchdog/sirfsoc_wdt.c
@@ -154,6 +154,7 @@ static int sirfsoc_wdt_probe(struct platform_device *pdev)
watchdog_init_timeout(&sirfsoc_wdd, timeout, &pdev->dev);
watchdog_set_nowayout(&sirfsoc_wdd, nowayout);
+ sirfsoc_wdd.parent = &pdev->dev;
ret = watchdog_register_device(&sirfsoc_wdd);
if (ret)
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 13/37] watchdog: sh: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (11 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 12/37] watchdog: sirfsoc: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 14/37] watchdog: s3c2410: " Pratyush Anand
` (24 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Paul Mundt
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/shwdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
index 567458b137a6..f90812170657 100644
--- a/drivers/watchdog/shwdt.c
+++ b/drivers/watchdog/shwdt.c
@@ -252,6 +252,7 @@ static int sh_wdt_probe(struct platform_device *pdev)
watchdog_set_nowayout(&sh_wdt_dev, nowayout);
watchdog_set_drvdata(&sh_wdt_dev, wdt);
+ sh_wdt_dev.parent = &pdev->dev;
spin_lock_init(&wdt->lock);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 14/37] watchdog: s3c2410: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (12 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 13/37] watchdog: sh: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 15/37] watchdog: rt2880: " Pratyush Anand
` (23 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Ben Dooks
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/s3c2410_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index e89ae027c91d..d781000c7825 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -607,6 +607,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
watchdog_set_nowayout(&wdt->wdt_device, nowayout);
wdt->wdt_device.bootstatus = s3c2410wdt_get_bootstatus(wdt);
+ wdt->wdt_device.parent = &pdev->dev;
ret = watchdog_register_device(&wdt->wdt_device);
if (ret) {
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 15/37] watchdog: rt2880: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (13 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 14/37] watchdog: s3c2410: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 16/37] watchdog: retu: " Pratyush Anand
` (22 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Gabor Juhos, John Crispin
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Gabor Juhos <juhosg@openwrt.org>
cc: John Crispin <blogic@openwrt.org>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/rt2880_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
index a6f7e2e29beb..1967919ae743 100644
--- a/drivers/watchdog/rt2880_wdt.c
+++ b/drivers/watchdog/rt2880_wdt.c
@@ -161,6 +161,7 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
rt288x_wdt_dev.dev = &pdev->dev;
rt288x_wdt_dev.bootstatus = rt288x_wdt_bootcause();
rt288x_wdt_dev.max_timeout = (0xfffful / rt288x_wdt_freq);
+ rt288x_wdt_dev.parent = &pdev->dev;
watchdog_init_timeout(&rt288x_wdt_dev, rt288x_wdt_dev.max_timeout,
&pdev->dev);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 16/37] watchdog: retu: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (14 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 15/37] watchdog: rt2880: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 17/37] watchdog: qcom: " Pratyush Anand
` (21 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Aaro Koskinen
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/retu_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/retu_wdt.c b/drivers/watchdog/retu_wdt.c
index b7c68e275aeb..39cd51df2ffc 100644
--- a/drivers/watchdog/retu_wdt.c
+++ b/drivers/watchdog/retu_wdt.c
@@ -127,6 +127,7 @@ static int retu_wdt_probe(struct platform_device *pdev)
retu_wdt->timeout = RETU_WDT_MAX_TIMER;
retu_wdt->min_timeout = 0;
retu_wdt->max_timeout = RETU_WDT_MAX_TIMER;
+ retu_wdt->parent = &pdev->dev;
watchdog_set_drvdata(retu_wdt, wdev);
watchdog_set_nowayout(retu_wdt, nowayout);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 17/37] watchdog: qcom: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (15 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 16/37] watchdog: retu: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 18/37] watchdog: pnx4008: " Pratyush Anand
` (20 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Josh Cartwright
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Josh Cartwright <joshc@codeaurora.org
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/qcom-wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
index aa03ca8f2d9b..773dcfaee7b2 100644
--- a/drivers/watchdog/qcom-wdt.c
+++ b/drivers/watchdog/qcom-wdt.c
@@ -171,6 +171,7 @@ static int qcom_wdt_probe(struct platform_device *pdev)
wdt->wdd.ops = &qcom_wdt_ops;
wdt->wdd.min_timeout = 1;
wdt->wdd.max_timeout = 0x10000000U / wdt->rate;
+ wdt->wdd.parent = &pdev->dev;
/*
* If 'timeout-sec' unspecified in devicetree, assume a 30 second
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 18/37] watchdog: pnx4008: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (16 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 17/37] watchdog: qcom: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 19/37] watchdog: orion: " Pratyush Anand
` (19 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog
Cc: dyoung, dzickus, Pratyush Anand, Dmitry Chigirev, Vitaly Wool
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Dmitry Chigirev <source@mvista.com>
cc: Vitaly Wool <vitalywool@gmail.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/pnx4008_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
index b9c6049c3e78..4224b3ec83a5 100644
--- a/drivers/watchdog/pnx4008_wdt.c
+++ b/drivers/watchdog/pnx4008_wdt.c
@@ -167,6 +167,7 @@ static int pnx4008_wdt_probe(struct platform_device *pdev)
pnx4008_wdd.bootstatus = (readl(WDTIM_RES(wdt_base)) & WDOG_RESET) ?
WDIOF_CARDRESET : 0;
+ pnx4008_wdd.parent = &pdev->dev;
watchdog_set_nowayout(&pnx4008_wdd, nowayout);
pnx4008_wdt_stop(&pnx4008_wdd); /* disable for now */
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 19/37] watchdog: orion: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (17 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 18/37] watchdog: pnx4008: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 20/37] watchdog: omap: " Pratyush Anand
` (18 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Sylver Bruneau
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Sylver Bruneau <sylver.bruneau@googlemail.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/orion_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
index ef0c628d5037..c6b8f4a43bde 100644
--- a/drivers/watchdog/orion_wdt.c
+++ b/drivers/watchdog/orion_wdt.c
@@ -567,6 +567,7 @@ static int orion_wdt_probe(struct platform_device *pdev)
dev->wdt.timeout = wdt_max_duration;
dev->wdt.max_timeout = wdt_max_duration;
+ dev->wdt.parent = &pdev->dev;
watchdog_init_timeout(&dev->wdt, heartbeat, &pdev->dev);
platform_set_drvdata(pdev, &dev->wdt);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 20/37] watchdog: omap: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (18 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 19/37] watchdog: orion: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 21/37] watchdog: menf21bmc: " Pratyush Anand
` (17 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, George G. Davis
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: George G. Davis <gdavis@mvista.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/omap_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index de911c7e477c..d96bee017fd3 100644
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -253,6 +253,7 @@ static int omap_wdt_probe(struct platform_device *pdev)
wdev->wdog.ops = &omap_wdt_ops;
wdev->wdog.min_timeout = TIMER_MARGIN_MIN;
wdev->wdog.max_timeout = TIMER_MARGIN_MAX;
+ wdev->wdog.parent = &pdev->dev;
if (watchdog_init_timeout(&wdev->wdog, timer_margin, &pdev->dev) < 0)
wdev->wdog.timeout = TIMER_MARGIN_DEFAULT;
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 21/37] watchdog: menf21bmc: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (19 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 20/37] watchdog: omap: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 22/37] watchdog: mena21: " Pratyush Anand
` (16 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Andreas Werner
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Andreas Werner <andreas.werner@men.de>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/menf21bmc_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/menf21bmc_wdt.c b/drivers/watchdog/menf21bmc_wdt.c
index 59f0913c7341..3aefddebb386 100644
--- a/drivers/watchdog/menf21bmc_wdt.c
+++ b/drivers/watchdog/menf21bmc_wdt.c
@@ -130,6 +130,7 @@ static int menf21bmc_wdt_probe(struct platform_device *pdev)
drv_data->wdt.info = &menf21bmc_wdt_info;
drv_data->wdt.min_timeout = BMC_WD_TIMEOUT_MIN;
drv_data->wdt.max_timeout = BMC_WD_TIMEOUT_MAX;
+ drv_data->wdt.parent = &pdev->dev;
drv_data->i2c_client = i2c_client;
/*
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 22/37] watchdog: mena21: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (20 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 21/37] watchdog: menf21bmc: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 6:48 ` Johannes Thumshirn
2015-08-18 4:47 ` [PATCH 23/37] watchdog: jz4740: " Pratyush Anand
` (15 subsequent siblings)
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Johannes Thumshirn
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/mena21_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/mena21_wdt.c b/drivers/watchdog/mena21_wdt.c
index d193a5e79c38..69013007dc47 100644
--- a/drivers/watchdog/mena21_wdt.c
+++ b/drivers/watchdog/mena21_wdt.c
@@ -197,6 +197,7 @@ static int a21_wdt_probe(struct platform_device *pdev)
watchdog_init_timeout(&a21_wdt, 30, &pdev->dev);
watchdog_set_nowayout(&a21_wdt, nowayout);
watchdog_set_drvdata(&a21_wdt, drv);
+ a21_wdt.parent = &pdev->dev;
reset = a21_wdt_get_bootstatus(drv);
if (reset == 2)
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 22/37] watchdog: mena21: Fix parent of watchdog_device
2015-08-18 4:47 ` [PATCH 22/37] watchdog: mena21: " Pratyush Anand
@ 2015-08-18 6:48 ` Johannes Thumshirn
0 siblings, 0 replies; 47+ messages in thread
From: Johannes Thumshirn @ 2015-08-18 6:48 UTC (permalink / raw)
To: Pratyush Anand; +Cc: linux-watchdog, dyoung, dzickus
Pratyush Anand <panand@redhat.com> writes:
> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> drivers/watchdog/mena21_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mena21_wdt.c b/drivers/watchdog/mena21_wdt.c
> index d193a5e79c38..69013007dc47 100644
> --- a/drivers/watchdog/mena21_wdt.c
> +++ b/drivers/watchdog/mena21_wdt.c
> @@ -197,6 +197,7 @@ static int a21_wdt_probe(struct platform_device *pdev)
> watchdog_init_timeout(&a21_wdt, 30, &pdev->dev);
> watchdog_set_nowayout(&a21_wdt, nowayout);
> watchdog_set_drvdata(&a21_wdt, drv);
> + a21_wdt.parent = &pdev->dev;
>
> reset = a21_wdt_get_bootstatus(drv);
> if (reset == 2)
Good catch
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 23/37] watchdog: jz4740: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (21 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 22/37] watchdog: mena21: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 24/37] watchdog: intel-mid: " Pratyush Anand
` (14 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Paul Cercueil
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/jz4740_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
index 4c2cc09c0c57..6a7d5c365438 100644
--- a/drivers/watchdog/jz4740_wdt.c
+++ b/drivers/watchdog/jz4740_wdt.c
@@ -174,6 +174,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
jz4740_wdt->timeout = heartbeat;
jz4740_wdt->min_timeout = 1;
jz4740_wdt->max_timeout = MAX_HEARTBEAT;
+ jz4740_wdt->parent = &pdev->dev;
watchdog_set_nowayout(jz4740_wdt, nowayout);
watchdog_set_drvdata(jz4740_wdt, drvdata);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 24/37] watchdog: intel-mid: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (22 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 23/37] watchdog: jz4740: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-20 18:24 ` David Cohen
2015-08-18 4:47 ` [PATCH 25/37] watchdog: ie6xx: " Pratyush Anand
` (13 subsequent siblings)
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, David Cohen
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/intel-mid_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 84f6701c391f..0a436b5d1e84 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -137,6 +137,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
wdt_dev->min_timeout = MID_WDT_TIMEOUT_MIN;
wdt_dev->max_timeout = MID_WDT_TIMEOUT_MAX;
wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
+ wdt_dev->parent = &pdev->dev;
watchdog_set_drvdata(wdt_dev, &pdev->dev);
platform_set_drvdata(pdev, wdt_dev);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 24/37] watchdog: intel-mid: Fix parent of watchdog_device
2015-08-18 4:47 ` [PATCH 24/37] watchdog: intel-mid: " Pratyush Anand
@ 2015-08-20 18:24 ` David Cohen
0 siblings, 0 replies; 47+ messages in thread
From: David Cohen @ 2015-08-20 18:24 UTC (permalink / raw)
To: Pratyush Anand; +Cc: linux-watchdog, dyoung, dzickus
On Tue, Aug 18, 2015 at 10:17:57AM +0530, Pratyush Anand wrote:
> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: David Cohen <david.a.cohen@linux.intel.com>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
Reviewed-by: David Cohen <david.a.cohen@linux.intel.com>
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 25/37] watchdog: ie6xx: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (23 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 24/37] watchdog: intel-mid: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:47 ` [PATCH 26/37] watchdog: gpio: " Pratyush Anand
` (12 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Alexander Stein
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Alexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/ie6xx_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/ie6xx_wdt.c b/drivers/watchdog/ie6xx_wdt.c
index 9bc39ae51624..78c2541f5d52 100644
--- a/drivers/watchdog/ie6xx_wdt.c
+++ b/drivers/watchdog/ie6xx_wdt.c
@@ -267,6 +267,7 @@ static int ie6xx_wdt_probe(struct platform_device *pdev)
ie6xx_wdt_dev.timeout = timeout;
watchdog_set_nowayout(&ie6xx_wdt_dev, nowayout);
+ ie6xx_wdt_dev.parent = &pdev->dev;
spin_lock_init(&ie6xx_wdt_data.unlock_sequence);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 26/37] watchdog: gpio: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (24 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 25/37] watchdog: ie6xx: " Pratyush Anand
@ 2015-08-18 4:47 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 27/37] watchdog: ep93xx: " Pratyush Anand
` (11 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:47 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Alexander Shiyan
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/gpio_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c
index 1687cc2d7122..336bddd84809 100644
--- a/drivers/watchdog/gpio_wdt.c
+++ b/drivers/watchdog/gpio_wdt.c
@@ -217,6 +217,7 @@ static int gpio_wdt_probe(struct platform_device *pdev)
priv->wdd.ops = &gpio_wdt_ops;
priv->wdd.min_timeout = SOFT_TIMEOUT_MIN;
priv->wdd.max_timeout = SOFT_TIMEOUT_MAX;
+ priv->wdd.parent = &pdev->dev;
if (watchdog_init_timeout(&priv->wdd, 0, &pdev->dev) < 0)
priv->wdd.timeout = SOFT_TIMEOUT_DEF;
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 27/37] watchdog: ep93xx: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (25 preceding siblings ...)
2015-08-18 4:47 ` [PATCH 26/37] watchdog: gpio: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 28/37] watchdog: digicolor: " Pratyush Anand
` (10 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog
Cc: dyoung, dzickus, Pratyush Anand, Ray Lehtiniemi, Alessandro Zummo
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Ray Lehtiniemi <rayl@mail.com>
cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/ep93xx_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/ep93xx_wdt.c b/drivers/watchdog/ep93xx_wdt.c
index 7a2cc7191c58..0a4d7cc05d54 100644
--- a/drivers/watchdog/ep93xx_wdt.c
+++ b/drivers/watchdog/ep93xx_wdt.c
@@ -132,6 +132,7 @@ static int ep93xx_wdt_probe(struct platform_device *pdev)
val = readl(mmio_base + EP93XX_WATCHDOG);
ep93xx_wdt_wdd.bootstatus = (val & 0x01) ? WDIOF_CARDRESET : 0;
ep93xx_wdt_wdd.timeout = timeout;
+ ep93xx_wdt_wdd.parent = &pdev->dev;
watchdog_set_nowayout(&ep93xx_wdt_wdd, nowayout);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 28/37] watchdog: digicolor: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (26 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 27/37] watchdog: ep93xx: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 5:41 ` Baruch Siach
2015-08-18 4:48 ` [PATCH 29/37] watchdog: davinci: " Pratyush Anand
` (9 subsequent siblings)
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Baruch Siach
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/digicolor_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 31d8e4936611..50abe1bf62a5 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -143,6 +143,7 @@ static int dc_wdt_probe(struct platform_device *pdev)
}
dc_wdt_wdd.max_timeout = U32_MAX / clk_get_rate(wdt->clk);
dc_wdt_wdd.timeout = dc_wdt_wdd.max_timeout;
+ dc_wdt_wdd.parent = &pdev->dev;
spin_lock_init(&wdt->lock);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 28/37] watchdog: digicolor: Fix parent of watchdog_device
2015-08-18 4:48 ` [PATCH 28/37] watchdog: digicolor: " Pratyush Anand
@ 2015-08-18 5:41 ` Baruch Siach
2015-08-18 6:03 ` Pratyush Anand
0 siblings, 1 reply; 47+ messages in thread
From: Baruch Siach @ 2015-08-18 5:41 UTC (permalink / raw)
To: Pratyush Anand; +Cc: linux-watchdog, dyoung, dzickus
Hi Pratyush Anand,
On Tue, Aug 18, 2015 at 10:18:01AM +0530, Pratyush Anand wrote:
> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> drivers/watchdog/digicolor_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 31d8e4936611..50abe1bf62a5 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -143,6 +143,7 @@ static int dc_wdt_probe(struct platform_device *pdev)
> }
> dc_wdt_wdd.max_timeout = U32_MAX / clk_get_rate(wdt->clk);
> dc_wdt_wdd.timeout = dc_wdt_wdd.max_timeout;
> + dc_wdt_wdd.parent = &pdev->dev;
Is there a reasonable way do this for all drivers (at least by default) in
generic code?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 47+ messages in thread* Re: [PATCH 28/37] watchdog: digicolor: Fix parent of watchdog_device
2015-08-18 5:41 ` Baruch Siach
@ 2015-08-18 6:03 ` Pratyush Anand
0 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 6:03 UTC (permalink / raw)
To: Baruch Siach; +Cc: linux-watchdog, dyoung, dzickus
Hi Baruch,
Thanks a lot for the question.
On 18/08/2015:08:41:36 AM, Baruch Siach wrote:
> Hi Pratyush Anand,
>
> On Tue, Aug 18, 2015 at 10:18:01AM +0530, Pratyush Anand wrote:
> > Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> > is populated.
> >
> > cc: Baruch Siach <baruch@tkos.co.il>
> > Signed-off-by: Pratyush Anand <panand@redhat.com>
> > ---
> > drivers/watchdog/digicolor_wdt.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> > index 31d8e4936611..50abe1bf62a5 100644
> > --- a/drivers/watchdog/digicolor_wdt.c
> > +++ b/drivers/watchdog/digicolor_wdt.c
> > @@ -143,6 +143,7 @@ static int dc_wdt_probe(struct platform_device *pdev)
> > }
> > dc_wdt_wdd.max_timeout = U32_MAX / clk_get_rate(wdt->clk);
> > dc_wdt_wdd.timeout = dc_wdt_wdd.max_timeout;
> > + dc_wdt_wdd.parent = &pdev->dev;
>
> Is there a reasonable way do this for all drivers (at least by default) in
> generic code?
watchdog_register_device does not have a arg with strcut device *.
Probably, we can do it in watchdog_init_timeout as a default.
But, all the driver does not call watchdog_init_timeout :(
$ git grep watchdog_init_timeout drivers/watchdog/ | wc -l
29
$ git grep watchdog_register_device drivers/watchdog/ | wc -l
67
So, Other than the implementation in patch series,
I do not see a way either without changing watchdog_register_device
prototype, or without calling watchdog_init_timeout from each driver.
~Pratyush
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 29/37] watchdog: davinci: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (27 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 28/37] watchdog: digicolor: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 30/37] watchdog: da9063: " Pratyush Anand
` (8 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Ivan Khoronzhuk
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/davinci_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
index cfdf8a408aea..17454ca653f4 100644
--- a/drivers/watchdog/davinci_wdt.c
+++ b/drivers/watchdog/davinci_wdt.c
@@ -179,6 +179,7 @@ static int davinci_wdt_probe(struct platform_device *pdev)
wdd->min_timeout = 1;
wdd->max_timeout = MAX_HEARTBEAT;
wdd->timeout = DEFAULT_HEARTBEAT;
+ wdd->parent = &pdev->dev;
watchdog_init_timeout(wdd, heartbeat, dev);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 30/37] watchdog: da9063: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (28 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 29/37] watchdog: davinci: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 31/37] watchdog: da9062: " Pratyush Anand
` (7 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Mariusz Wojtasik
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Mariusz Wojtasik <mariusz.wojtasik@diasemi.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/da9063_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/da9063_wdt.c b/drivers/watchdog/da9063_wdt.c
index e2fe2ebdebd4..6bf130bd863d 100644
--- a/drivers/watchdog/da9063_wdt.c
+++ b/drivers/watchdog/da9063_wdt.c
@@ -175,6 +175,7 @@ static int da9063_wdt_probe(struct platform_device *pdev)
wdt->wdtdev.min_timeout = DA9063_WDT_MIN_TIMEOUT;
wdt->wdtdev.max_timeout = DA9063_WDT_MAX_TIMEOUT;
wdt->wdtdev.timeout = DA9063_WDG_TIMEOUT;
+ wdt->wdtdev.parent = &pdev->dev;
wdt->wdtdev.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 31/37] watchdog: da9062: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (29 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 30/37] watchdog: da9063: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 32/37] watchdog: da9055: " Pratyush Anand
` (6 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, S Twiss
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: S Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/da9062_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
index b3a870ce85be..7386111220d5 100644
--- a/drivers/watchdog/da9062_wdt.c
+++ b/drivers/watchdog/da9062_wdt.c
@@ -210,6 +210,7 @@ static int da9062_wdt_probe(struct platform_device *pdev)
wdt->wdtdev.max_timeout = DA9062_WDT_MAX_TIMEOUT;
wdt->wdtdev.timeout = DA9062_WDG_DEFAULT_TIMEOUT;
wdt->wdtdev.status = WATCHDOG_NOWAYOUT_INIT_STATUS;
+ wdt->wdtdev.parent = &pdev->dev;
watchdog_set_drvdata(&wdt->wdtdev, wdt);
dev_set_drvdata(&pdev->dev, wdt);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 32/37] watchdog: da9055: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (30 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 31/37] watchdog: da9062: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 33/37] watchdog: da9052: " Pratyush Anand
` (5 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, David Dajun Chen
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: David Dajun Chen <dchen@diasemi.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/da9055_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c
index 495089d8dbfe..04d1430d93d2 100644
--- a/drivers/watchdog/da9055_wdt.c
+++ b/drivers/watchdog/da9055_wdt.c
@@ -161,6 +161,7 @@ static int da9055_wdt_probe(struct platform_device *pdev)
da9055_wdt->timeout = DA9055_DEF_TIMEOUT;
da9055_wdt->info = &da9055_wdt_info;
da9055_wdt->ops = &da9055_wdt_ops;
+ da9055_wdt->parent = &pdev->dev;
watchdog_set_nowayout(da9055_wdt, nowayout);
watchdog_set_drvdata(da9055_wdt, driver_data);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 33/37] watchdog: da9052: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (31 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 32/37] watchdog: da9055: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 34/37] watchdog: coh901327: " Pratyush Anand
` (4 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Anthony Olech
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Anthony Olech <Anthony.Olech@diasemi.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/da9052_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
index 2e9589652e1e..67e67977bd29 100644
--- a/drivers/watchdog/da9052_wdt.c
+++ b/drivers/watchdog/da9052_wdt.c
@@ -195,6 +195,7 @@ static int da9052_wdt_probe(struct platform_device *pdev)
da9052_wdt->timeout = DA9052_DEF_TIMEOUT;
da9052_wdt->info = &da9052_wdt_info;
da9052_wdt->ops = &da9052_wdt_ops;
+ da9052_wdt->parent = &pdev->dev;
watchdog_set_drvdata(da9052_wdt, driver_data);
kref_init(&driver_data->kref);
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 34/37] watchdog: coh901327: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (32 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 33/37] watchdog: da9052: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 35/37] watchdog: bcm_kona: " Pratyush Anand
` (3 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Linus Walleij
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/coh901327_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index ce12f437f195..a099b77fc0b9 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -358,6 +358,7 @@ static int __init coh901327_probe(struct platform_device *pdev)
if (ret < 0)
coh901327_wdt.timeout = 60;
+ coh901327_wdt.parent = &pdev->dev;
ret = watchdog_register_device(&coh901327_wdt);
if (ret == 0)
dev_info(&pdev->dev,
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 35/37] watchdog: bcm_kona: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (33 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 34/37] watchdog: coh901327: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 36/37] watchdog: bcm47xx: " Pratyush Anand
` (2 subsequent siblings)
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Markus Mayer
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Markus Mayer <mmayer@broadcom.com>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/bcm_kona_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
index 22d8ae65772a..e0c98423f2c9 100644
--- a/drivers/watchdog/bcm_kona_wdt.c
+++ b/drivers/watchdog/bcm_kona_wdt.c
@@ -319,6 +319,7 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
spin_lock_init(&wdt->lock);
platform_set_drvdata(pdev, wdt);
watchdog_set_drvdata(&bcm_kona_wdt_wdd, wdt);
+ bcm_kona_wdt_wdd.parent = &pdev->dev;
ret = bcm_kona_wdt_set_timeout_reg(&bcm_kona_wdt_wdd, 0);
if (ret) {
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 36/37] watchdog: bcm47xx: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (34 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 35/37] watchdog: bcm_kona: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 4:48 ` [PATCH 37/37] watchdog: bcm2835: " Pratyush Anand
2015-08-18 15:48 ` [PATCH 00/37] watchdog: Fix parent of watchdog devices Guenter Roeck
37 siblings, 0 replies; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Hauke Mehrtens
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/bcm47xx_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/bcm47xx_wdt.c b/drivers/watchdog/bcm47xx_wdt.c
index b28a072abf78..4064a43f1360 100644
--- a/drivers/watchdog/bcm47xx_wdt.c
+++ b/drivers/watchdog/bcm47xx_wdt.c
@@ -209,6 +209,7 @@ static int bcm47xx_wdt_probe(struct platform_device *pdev)
wdt->wdd.info = &bcm47xx_wdt_info;
wdt->wdd.timeout = WDT_DEFAULT_TIME;
+ wdt->wdd.parent = &pdev->dev;
ret = wdt->wdd.ops->set_timeout(&wdt->wdd, timeout);
if (ret)
goto err_timer;
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 37/37] watchdog: bcm2835: Fix parent of watchdog_device
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (35 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 36/37] watchdog: bcm47xx: " Pratyush Anand
@ 2015-08-18 4:48 ` Pratyush Anand
2015-08-18 20:25 ` Lubomir Rintel
2015-08-18 15:48 ` [PATCH 00/37] watchdog: Fix parent of watchdog devices Guenter Roeck
37 siblings, 1 reply; 47+ messages in thread
From: Pratyush Anand @ 2015-08-18 4:48 UTC (permalink / raw)
To: linux-watchdog; +Cc: dyoung, dzickus, Pratyush Anand, Lubomir Rintel
Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
is populated.
cc: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Pratyush Anand <panand@redhat.com>
---
drivers/watchdog/bcm2835_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
index 7116968dee12..66c3e656a616 100644
--- a/drivers/watchdog/bcm2835_wdt.c
+++ b/drivers/watchdog/bcm2835_wdt.c
@@ -182,6 +182,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
watchdog_set_drvdata(&bcm2835_wdt_wdd, wdt);
watchdog_init_timeout(&bcm2835_wdt_wdd, heartbeat, dev);
watchdog_set_nowayout(&bcm2835_wdt_wdd, nowayout);
+ bcm2835_wdt_wdd.parent = &pdev->dev;
err = watchdog_register_device(&bcm2835_wdt_wdd);
if (err) {
dev_err(dev, "Failed to register watchdog device");
--
2.4.3
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 37/37] watchdog: bcm2835: Fix parent of watchdog_device
2015-08-18 4:48 ` [PATCH 37/37] watchdog: bcm2835: " Pratyush Anand
@ 2015-08-18 20:25 ` Lubomir Rintel
0 siblings, 0 replies; 47+ messages in thread
From: Lubomir Rintel @ 2015-08-18 20:25 UTC (permalink / raw)
To: Pratyush Anand, linux-watchdog; +Cc: dyoung, dzickus
On Tue, 2015-08-18 at 10:18 +0530, Pratyush Anand wrote:
> Fix parent of watchdog_device so that
> /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
Thank you!
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/watchdog/bcm2835_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/bcm2835_wdt.c
> b/drivers/watchdog/bcm2835_wdt.c
> index 7116968dee12..66c3e656a616 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -182,6 +182,7 @@ static int bcm2835_wdt_probe(struct
> platform_device *pdev)
> watchdog_set_drvdata(&bcm2835_wdt_wdd, wdt);
> watchdog_init_timeout(&bcm2835_wdt_wdd, heartbeat, dev);
> watchdog_set_nowayout(&bcm2835_wdt_wdd, nowayout);
> + bcm2835_wdt_wdd.parent = &pdev->dev;
> err = watchdog_register_device(&bcm2835_wdt_wdd);
> if (err) {
> dev_err(dev, "Failed to register watchdog device");
^ permalink raw reply [flat|nested] 47+ messages in thread
* Re: [PATCH 00/37] watchdog: Fix parent of watchdog devices
2015-08-18 4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
` (36 preceding siblings ...)
2015-08-18 4:48 ` [PATCH 37/37] watchdog: bcm2835: " Pratyush Anand
@ 2015-08-18 15:48 ` Guenter Roeck
2015-08-18 16:39 ` Pratyush Anand
37 siblings, 1 reply; 47+ messages in thread
From: Guenter Roeck @ 2015-08-18 15:48 UTC (permalink / raw)
To: Pratyush Anand, linux-watchdog; +Cc: dyoung, dzickus
On 08/17/2015 09:47 PM, Pratyush Anand wrote:
> Hi,
>
> I posted a query here (https://lkml.org/lkml/2015/8/10/19), but did not get any
> feedback. So, thought to post patches and to seek response.
>
> I need some way to identify the driver/module for a given watchdog node say
> /dev/watchdog0.
>
> Documentation/watchdog/watchdog-api.txt says:
> identity a string identifying the watchdog driver
>
> However, all the watchdog driver does not define identity as DRV_NAME.
>
> Otherway could be to look for /sys/class/watchdog/watchdog0/device/modalias.
>
> However, many wdt devices does not set its parent and so, we do not see an entry
> for /sys/class/watchdog/watchdog0/device/ in sysfs.
>
> This patch set fixes parent for wdt drivers written in watchdog-core framework.
>
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can identify driver for these devices.
>
Series makes sense, but imposes a huge burden on the maintainer.
I think this is one of those changes where a single patch would make much more sense.
I merged all patches into my test repository for build and runtime tests,
but I would suggest to resubmit the series as a single patch.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 47+ messages in thread