Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org, Jamie Iles <jamie@jamieiles.com>
Subject: Re: [PATCH v2] watchdog: dw_wdt: remove build dependencies
Date: Mon, 30 Dec 2013 19:35:23 +0000	[thread overview]
Message-ID: <20131230193523.GA3640@maple> (raw)
In-Reply-To: <a41f433ac50ef0da9e9eae0e793119cb4e88b9e3.1388406354.git.baruch@tkos.co.il>

Hi Baruch,

Looks good, thanks!

Acked-by: Jamie Iles <jamie@jamieiles.com>

Jamie

On Mon, Dec 30, 2013 at 02:25:54PM +0200, Baruch Siach wrote:
> There is nothing ARM specific in this driver, and we intend to use it on the
> Xtensa architecture. Also, clk.h now includes stubs for !CONFIG_HAVE_CLK, so
> the driver should build anyway.
> 
> Cc: Jamie Iles <jamie@jamieiles.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v2:
>     Don't mention ARM in the Kconfig help text, and source comment
> 
>     Mention in the commit log message that this driver is used on Xtensa
> ---
>  drivers/watchdog/Kconfig  | 3 +--
>  drivers/watchdog/dw_wdt.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 5be6e91..d3bcad0 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -214,10 +214,9 @@ config SA1100_WATCHDOG
>  
>  config DW_WATCHDOG
>  	tristate "Synopsys DesignWare watchdog"
> -	depends on ARM && HAVE_CLK
>  	help
>  	  Say Y here if to include support for the Synopsys DesignWare
> -	  watchdog timer found in many ARM chips.
> +	  watchdog timer found in many chips.
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called dw_wdt.
>  
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index a46f5c7..ee4f86b 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -8,7 +8,7 @@
>   * 2 of the License, or (at your option) any later version.
>   *
>   * This file implements a driver for the Synopsys DesignWare watchdog device
> - * in the many ARM subsystems. The watchdog has 16 different timeout periods
> + * in the many subsystems. The watchdog has 16 different timeout periods
>   * and these are a function of the input clock frequency.
>   *
>   * The DesignWare watchdog cannot be stopped once it has been started so we
> -- 
> 1.8.5.2
> 

  reply	other threads:[~2013-12-30 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 12:25 [PATCH v2] watchdog: dw_wdt: remove build dependencies Baruch Siach
2013-12-30 19:35 ` Jamie Iles [this message]
2014-01-13 20:01 ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131230193523.GA3640@maple \
    --to=jamie@jamieiles.com \
    --cc=baruch@tkos.co.il \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox