Linux Watchdog driver development
 help / color / mirror / Atom feed
* [PATCH v2] watchdog: dw_wdt: remove build dependencies
@ 2013-12-30 12:25 Baruch Siach
  2013-12-30 19:35 ` Jamie Iles
  2014-01-13 20:01 ` Wim Van Sebroeck
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2013-12-30 12:25 UTC (permalink / raw)
  To: Wim Van Sebroeck; +Cc: linux-watchdog, Baruch Siach, Jamie Iles

There is nothing ARM specific in this driver, and we intend to use it on the
Xtensa architecture. Also, clk.h now includes stubs for !CONFIG_HAVE_CLK, so
the driver should build anyway.

Cc: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2:
    Don't mention ARM in the Kconfig help text, and source comment

    Mention in the commit log message that this driver is used on Xtensa
---
 drivers/watchdog/Kconfig  | 3 +--
 drivers/watchdog/dw_wdt.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 5be6e91..d3bcad0 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -214,10 +214,9 @@ config SA1100_WATCHDOG
 
 config DW_WATCHDOG
 	tristate "Synopsys DesignWare watchdog"
-	depends on ARM && HAVE_CLK
 	help
 	  Say Y here if to include support for the Synopsys DesignWare
-	  watchdog timer found in many ARM chips.
+	  watchdog timer found in many chips.
 	  To compile this driver as a module, choose M here: the
 	  module will be called dw_wdt.
 
diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index a46f5c7..ee4f86b 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -8,7 +8,7 @@
  * 2 of the License, or (at your option) any later version.
  *
  * This file implements a driver for the Synopsys DesignWare watchdog device
- * in the many ARM subsystems. The watchdog has 16 different timeout periods
+ * in the many subsystems. The watchdog has 16 different timeout periods
  * and these are a function of the input clock frequency.
  *
  * The DesignWare watchdog cannot be stopped once it has been started so we
-- 
1.8.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: dw_wdt: remove build dependencies
  2013-12-30 12:25 [PATCH v2] watchdog: dw_wdt: remove build dependencies Baruch Siach
@ 2013-12-30 19:35 ` Jamie Iles
  2014-01-13 20:01 ` Wim Van Sebroeck
  1 sibling, 0 replies; 3+ messages in thread
From: Jamie Iles @ 2013-12-30 19:35 UTC (permalink / raw)
  To: Baruch Siach; +Cc: Wim Van Sebroeck, linux-watchdog, Jamie Iles

Hi Baruch,

Looks good, thanks!

Acked-by: Jamie Iles <jamie@jamieiles.com>

Jamie

On Mon, Dec 30, 2013 at 02:25:54PM +0200, Baruch Siach wrote:
> There is nothing ARM specific in this driver, and we intend to use it on the
> Xtensa architecture. Also, clk.h now includes stubs for !CONFIG_HAVE_CLK, so
> the driver should build anyway.
> 
> Cc: Jamie Iles <jamie@jamieiles.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v2:
>     Don't mention ARM in the Kconfig help text, and source comment
> 
>     Mention in the commit log message that this driver is used on Xtensa
> ---
>  drivers/watchdog/Kconfig  | 3 +--
>  drivers/watchdog/dw_wdt.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 5be6e91..d3bcad0 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -214,10 +214,9 @@ config SA1100_WATCHDOG
>  
>  config DW_WATCHDOG
>  	tristate "Synopsys DesignWare watchdog"
> -	depends on ARM && HAVE_CLK
>  	help
>  	  Say Y here if to include support for the Synopsys DesignWare
> -	  watchdog timer found in many ARM chips.
> +	  watchdog timer found in many chips.
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called dw_wdt.
>  
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index a46f5c7..ee4f86b 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -8,7 +8,7 @@
>   * 2 of the License, or (at your option) any later version.
>   *
>   * This file implements a driver for the Synopsys DesignWare watchdog device
> - * in the many ARM subsystems. The watchdog has 16 different timeout periods
> + * in the many subsystems. The watchdog has 16 different timeout periods
>   * and these are a function of the input clock frequency.
>   *
>   * The DesignWare watchdog cannot be stopped once it has been started so we
> -- 
> 1.8.5.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] watchdog: dw_wdt: remove build dependencies
  2013-12-30 12:25 [PATCH v2] watchdog: dw_wdt: remove build dependencies Baruch Siach
  2013-12-30 19:35 ` Jamie Iles
@ 2014-01-13 20:01 ` Wim Van Sebroeck
  1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2014-01-13 20:01 UTC (permalink / raw)
  To: Baruch Siach; +Cc: linux-watchdog, Jamie Iles

Hi Baruch,

> There is nothing ARM specific in this driver, and we intend to use it on the
> Xtensa architecture. Also, clk.h now includes stubs for !CONFIG_HAVE_CLK, so
> the driver should build anyway.
> 
> Cc: Jamie Iles <jamie@jamieiles.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Added to linux-watchdog-next.

Kind regards,
Wim.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-13 20:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 12:25 [PATCH v2] watchdog: dw_wdt: remove build dependencies Baruch Siach
2013-12-30 19:35 ` Jamie Iles
2014-01-13 20:01 ` Wim Van Sebroeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox