Re: [PATCH 1/3] watchdog: omap: use watchdog_init_timeout

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

On Fri, Apr 24, 2015 at 09:42:59AM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Apr 24, 2015 at 11:48:31AM +0200, Uwe Kleine-König wrote:
> > Instead of (partly) open coding it use the core function. As a side
> > effect the "timeout-sec" devicetree property is used now.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/watchdog/omap-wdt.txt | 9 +++++----
> >  drivers/watchdog/omap_wdt.c                             | 5 +----
> >  2 files changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> > index c227970671ea..4f18ec38be2f 100644
> > --- a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> > +++ b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> > @@ -1,10 +1,11 @@
> >  TI Watchdog Timer (WDT) Controller for OMAP
> >  
> >  Required properties:
> > -compatible:
> > -- "ti,omap3-wdt" for OMAP3
> > -- "ti,omap4-wdt" for OMAP4
> > -- ti,hwmods: Name of the hwmod associated to the WDT
> > +- compatible : "ti,omap3-wdt" (for OMAP3) or "ti,omap4-wdt" (for OMAP4)
> > +- ti,hwmods : Name of the hwmod associated to the WDT
> > +
> > +Optional properties:
> > +- timeout-sec : default watchdog timeout in seconds
> 
> adding a new property here ? Why ? In fact, none of these DT binding doc
> changes fit in $subject. Sure, watchdog_init_timeout() needs
> timeout-sec, but no OMAP DT today passes it.
watchdog_init_timeout doesn't *need* the new property. After all it's
optional. The other changes are just reformatting to make it match the
usual style and make it understandable. Could have mentioned it in the
commitlog, that's true.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |