From: Felipe Balbi <balbi@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Felipe Balbi <balbi@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>,
Wim Van Sebroeck <wim@iguana.be>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation
Date: Fri, 24 Apr 2015 21:10:24 -0500 [thread overview]
Message-ID: <20150425021024.GA14963@saruman.tx.rr.com> (raw)
In-Reply-To: <1429906850-5420-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote:
> ti,hwmods doesn't belong into the compatible section but is a property
> on it's own. Also reformat the section of required properties to match the
> usual style of dt binding documents.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
looks great to me, thanks
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> Hello Felipe,
>
> what about this patch before the previously sent patch 1?
>
> Best regards
> Uwe
>
> Documentation/devicetree/bindings/watchdog/omap-wdt.txt | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> index c227970671ea..597e19d18dca 100644
> --- a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> @@ -1,10 +1,8 @@
> TI Watchdog Timer (WDT) Controller for OMAP
>
> Required properties:
> -compatible:
> -- "ti,omap3-wdt" for OMAP3
> -- "ti,omap4-wdt" for OMAP4
> -- ti,hwmods: Name of the hwmod associated to the WDT
> +- compatible : "ti,omap3-wdt" for OMAP3 or "ti,omap4-wdt" for OMAP4
> +- ti,hwmods : Name of the hwmod associated to the WDT
>
> Examples:
>
> --
> 2.1.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-25 2:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 9:48 [PATCH 0/3] watchdog: omap: several cleanups Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 1/3] watchdog: omap: use watchdog_init_timeout Uwe Kleine-König
2015-04-24 14:42 ` Felipe Balbi
2015-04-24 19:02 ` Uwe Kleine-König
2015-04-24 20:20 ` [PATCH 1a/3] watchdog: omap: clearify device tree documentation Uwe Kleine-König
2015-04-25 2:10 ` Felipe Balbi [this message]
2015-04-26 15:29 ` Guenter Roeck
2015-04-26 19:12 ` Uwe Kleine-König
2015-04-26 19:46 ` Guenter Roeck
2015-04-24 9:48 ` [PATCH 2/3] watchdog: omap: put struct watchdog_device into driver data Uwe Kleine-König
2015-04-24 14:44 ` Felipe Balbi
2015-04-24 19:10 ` Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus Uwe Kleine-König
2015-04-24 14:45 ` Felipe Balbi
2015-04-24 19:03 ` Uwe Kleine-König
2015-04-26 15:28 ` Guenter Roeck
2015-04-26 19:14 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425021024.GA14963@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox