From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-watchdog@vger.kernel.org,
"Wim Van Sebroeck" <wim@iguana.be>
Cc: Lokesh Vutla <lokeshvutla@ti.com>, Felipe Balbi <balbi@ti.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus
Date: Sun, 26 Apr 2015 08:28:16 -0700 [thread overview]
Message-ID: <553D0410.4010802@roeck-us.net> (raw)
In-Reply-To: <20150424190317.GV19431@pengutronix.de>
On 04/24/2015 12:03 PM, Uwe Kleine-König wrote:
> On Fri, Apr 24, 2015 at 11:48:33AM +0200, Uwe Kleine-König wrote:
>> Instead of using an over-long expression involving the ?: operator use
>> an if and intead of an else branch rely on the fact that the data
> just noticed ^^ there is an s missing ...
>
> Wim, if you apply this version, can you fix that up?
>
Hi Uwe,
if you don't mind, can you sesend the entire series ?
I don't think patch 1 applies after 1a, and it might make sense
to add some more explanation to patch 2. FWIW, I would say that using
to_omap_wdt_dev() instead of watchdog_get_drvdata() simplifies the code,
or simply that the functions are no longer needed in the driver (ugliness
may be seen as personal opinion).
When you do so, please feel free to add
Reviewed-by: Guenter Roeck <linux@roeck-us.net> to all four patches.
Thanks,
Guenter
next prev parent reply other threads:[~2015-04-26 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 9:48 [PATCH 0/3] watchdog: omap: several cleanups Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 1/3] watchdog: omap: use watchdog_init_timeout Uwe Kleine-König
2015-04-24 14:42 ` Felipe Balbi
2015-04-24 19:02 ` Uwe Kleine-König
2015-04-24 20:20 ` [PATCH 1a/3] watchdog: omap: clearify device tree documentation Uwe Kleine-König
2015-04-25 2:10 ` Felipe Balbi
2015-04-26 15:29 ` Guenter Roeck
2015-04-26 19:12 ` Uwe Kleine-König
2015-04-26 19:46 ` Guenter Roeck
2015-04-24 9:48 ` [PATCH 2/3] watchdog: omap: put struct watchdog_device into driver data Uwe Kleine-König
2015-04-24 14:44 ` Felipe Balbi
2015-04-24 19:10 ` Uwe Kleine-König
2015-04-24 9:48 ` [PATCH 3/3] watchdog: omap: simplify assignment of bootstatus Uwe Kleine-König
2015-04-24 14:45 ` Felipe Balbi
2015-04-24 19:03 ` Uwe Kleine-König
2015-04-26 15:28 ` Guenter Roeck [this message]
2015-04-26 19:14 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553D0410.4010802@roeck-us.net \
--to=linux@roeck-us.net \
--cc=balbi@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox