Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Radu Rendec <rrendec@arista.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org
Subject: [PATCH v2 0/2] xen_wdt: use the watchdog subsystem
Date: Mon,  6 Nov 2017 19:04:10 +0000	[thread overview]
Message-ID: <20171106190412.10023-1-rrendec@arista.com> (raw)
In-Reply-To: <20171106180416.GA12199@roeck-us.net>

On Mon, 2017-11-06 at 10:04 -0800, Guenter Roeck wrote:
> On Mon, Nov 06, 2017 at 05:39:03PM +0000, Radu Rendec wrote:
> > I see your point, but I think module_platform_driver_probe() can't be
> > used here. The problem is that there's nothing else to create the
> > platform device, so if xen_wdt doesn't create it on its own, there will
> > be no (matching) platform device to be probed by the driver that
> > xen_wdt registers.
[snip]
> > I already fixed the other issues in the previous patch so, unless you
> > think init/exit can be simplified in a different way, I am ready to
> > resend the (updated) patches.
> >
>
> Ok; thanks for having a look.

You're welcome. Attaching the updated patches.

By the way, I tried to replace pr_* with dev_* but then the messages
look kind of funny, e.g.
wdt wdt: initialized (timeout=60s, nowayout=0)
instead of:
xen_wdt: initialized (timeout=60s, nowayout=0)

I thought this would be more confusing than useful to the user, so I
reverted back to pr_*.

Thanks,
Radu


Radu Rendec (2):
  watchdog: xen_wdt: use the watchdog subsystem
  watchdog: xen_wdt: remove info message and version number

 drivers/watchdog/xen_wdt.c | 243 +++++++++------------------------------------
 1 file changed, 49 insertions(+), 194 deletions(-)

-- 
2.13.6


  reply	other threads:[~2017-11-06 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 15:31 [PATCH 0/2] xen_wdt: use the watchdog subsystem Radu Rendec
2017-11-03 15:31 ` [PATCH 1/2] watchdog: " Radu Rendec
2017-11-05 15:35   ` [1/2] " Guenter Roeck
2017-11-03 15:31 ` [PATCH 2/2] watchdog: xen_wdt: remove info message and version number Radu Rendec
2017-11-05 15:39   ` [2/2] " Guenter Roeck
2017-11-06 17:39     ` Radu Rendec
2017-11-06 18:04       ` Guenter Roeck
2017-11-06 19:04         ` Radu Rendec [this message]
2017-11-06 19:04           ` [PATCH v2 1/2] watchdog: xen_wdt: use the watchdog subsystem Radu Rendec
2017-11-11 16:40             ` [v2,1/2] " Guenter Roeck
2017-11-14 15:05               ` Radu Rendec
2017-11-06 19:04           ` [PATCH v2 2/2] watchdog: xen_wdt: remove info message and version number Radu Rendec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106190412.10023-1-rrendec@arista.com \
    --to=rrendec@arista.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox