From: Guenter Roeck <linux@roeck-us.net>
To: Radu Rendec <rrendec@arista.com>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org
Subject: Re: [2/2] watchdog: xen_wdt: remove info message and version number
Date: Sun, 5 Nov 2017 07:39:10 -0800 [thread overview]
Message-ID: <20171105153910.GA28756@roeck-us.net> (raw)
In-Reply-To: <20171103153153.9992-3-rrendec@arista.com>
On Fri, Nov 03, 2017 at 03:31:53PM +0000, Radu Rendec wrote:
> The initial info message (early in the xen_wdt_init_module() function)
> is not very useful and we already have a message on successful probe. If
> the probe fails, additional messages are printed anyway.
>
> The version number serves no useful purpose and it ran out of favor
> upstream anyway.
>
> Signed-off-by: Radu Rendec <rrendec@arista.com>
> ---
> drivers/watchdog/xen_wdt.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/watchdog/xen_wdt.c b/drivers/watchdog/xen_wdt.c
> index 8bea946dfdc7..e1aeff0ea6eb 100644
> --- a/drivers/watchdog/xen_wdt.c
> +++ b/drivers/watchdog/xen_wdt.c
> @@ -12,7 +12,6 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> #define DRV_NAME "wdt"
> -#define DRV_VERSION "0.01"
>
> #include <linux/bug.h>
> #include <linux/errno.h>
> @@ -203,8 +202,6 @@ static int __init xen_wdt_init_module(void)
> if (!xen_domain())
> return -ENODEV;
>
> - pr_info("Xen WatchDog Timer Driver v%s\n", DRV_VERSION);
> -
> err = platform_driver_register(&xen_wdt_driver);
> if (err)
> return err;
> @@ -231,5 +228,4 @@ module_exit(xen_wdt_cleanup_module);
>
As I mentioned in the other patch, any chance to use
module_platform_driver_probe() ? The
if (!xen_domain())
return -ENODEV;
could be moved there.
Thanks,
Guenter
> MODULE_AUTHOR("Jan Beulich <jbeulich@novell.com>");
> MODULE_DESCRIPTION("Xen WatchDog Timer Driver");
> -MODULE_VERSION(DRV_VERSION);
> MODULE_LICENSE("GPL");
next prev parent reply other threads:[~2017-11-05 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:31 [PATCH 0/2] xen_wdt: use the watchdog subsystem Radu Rendec
2017-11-03 15:31 ` [PATCH 1/2] watchdog: " Radu Rendec
2017-11-05 15:35 ` [1/2] " Guenter Roeck
2017-11-03 15:31 ` [PATCH 2/2] watchdog: xen_wdt: remove info message and version number Radu Rendec
2017-11-05 15:39 ` Guenter Roeck [this message]
2017-11-06 17:39 ` [2/2] " Radu Rendec
2017-11-06 18:04 ` Guenter Roeck
2017-11-06 19:04 ` [PATCH v2 0/2] xen_wdt: use the watchdog subsystem Radu Rendec
2017-11-06 19:04 ` [PATCH v2 1/2] watchdog: " Radu Rendec
2017-11-11 16:40 ` [v2,1/2] " Guenter Roeck
2017-11-14 15:05 ` Radu Rendec
2017-11-06 19:04 ` [PATCH v2 2/2] watchdog: xen_wdt: remove info message and version number Radu Rendec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105153910.GA28756@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=rrendec@arista.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox