* [PATCH] watchdog: imx2_wdg: Declare local symbols static
@ 2023-02-28 15:16 Guenter Roeck
2023-03-02 8:03 ` Andrej Picej
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2023-02-28 15:16 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: linux-watchdog, linux-kernel, Guenter Roeck, Andrej Picej
0-day complains:
drivers/watchdog/imx2_wdt.c:442:22: sparse:
symbol 'imx_wdt' was not declared. Should it be static?
drivers/watchdog/imx2_wdt.c:446:22: sparse:
symbol 'imx_wdt_legacy' was not declared. Should it be static?
Declare as static variables.
Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
Cc: Andrej Picej <andrej.picej@norik.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/imx2_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 19ab7b3d286b..6fcc3596103c 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -439,11 +439,11 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(imx2_wdt_pm_ops, imx2_wdt_suspend,
imx2_wdt_resume);
-struct imx2_wdt_data imx_wdt = {
+static struct imx2_wdt_data imx_wdt = {
.wdw_supported = true,
};
-struct imx2_wdt_data imx_wdt_legacy = {
+static struct imx2_wdt_data imx_wdt_legacy = {
.wdw_supported = false,
};
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: imx2_wdg: Declare local symbols static
2023-02-28 15:16 [PATCH] watchdog: imx2_wdg: Declare local symbols static Guenter Roeck
@ 2023-03-02 8:03 ` Andrej Picej
0 siblings, 0 replies; 2+ messages in thread
From: Andrej Picej @ 2023-03-02 8:03 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel
On 28. 02. 23 16:16, Guenter Roeck wrote:
> 0-day complains:
>
> drivers/watchdog/imx2_wdt.c:442:22: sparse:
> symbol 'imx_wdt' was not declared. Should it be static?
> drivers/watchdog/imx2_wdt.c:446:22: sparse:
> symbol 'imx_wdt_legacy' was not declared. Should it be static?
>
> Declare as static variables.
>
> Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
> Cc: Andrej Picej <andrej.picej@norik.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Hi Guenter,
thanks for the fix. Sorry for the trouble.
Best regards,
Andrej
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-02 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-28 15:16 [PATCH] watchdog: imx2_wdg: Declare local symbols static Guenter Roeck
2023-03-02 8:03 ` Andrej Picej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox