Re: [PATCH 01/11] dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] YAML sequence indentation violates the subsystem's yamllint rules (`indent-sequences: true`), causing `make dt_binding_check` to fail.
--

--- Patch [1]: [PATCH 01/11] dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x) ---
commit 8fa154a194ffbacee86322faaaf7374a3dd8929a
Author: Janne Grunau <j@jannau.net>

dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x)

This commit introduces device tree bindings for the Apple M3 Pro, Max, and
Ultra SoCs (T6030, T6031, T6032, and T6034). It documents the compatible
strings for these new platforms along with the corresponding devices they
power.

> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index e49403c73f9d2..111c28d94736b 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml

[ ... ]

> @@ -365,6 +373,35 @@ properties:
>            - const: apple,t6022
>            - const: apple,arm-platform
>  
> +      - description: Apple M3 Pro SoC based platforms
> +        items:
> +          - enum:
> +            - apple,j514s # MacBook Pro (14-inch, M3 Pro, 2023)
> +            - apple,j516s # MacBook Pro (16-inch, M3 Pro, 2023)

[Severity: Low]
Does this formatting regression cause make dt_binding_check to fail? The
sequence indicators for apple,j514s and apple,j516s are at the same
indentation level as their parent enum: key. Should they be indented by an
additional 2 spaces to comply with the subsystem's indent-sequences: true
yamllint rule?

> +          - const: apple,t6030
> +          - const: apple,arm-platform
> +
> +      - description: Apple M3 Max SoC based platforms
> +        oneOf:
> +          - items:
> +            - enum:
> +              - apple,j514c # MacBook Pro (14-inch, M3 Max, 16 cores, 2023)
> +              - apple,j516c # MacBook Pro (16-inch, M3 Max, 16 cores, 2023)

[Severity: Low]
Is the indentation correct here as well? The sequence indicators for the
inner enum sequences (- apple,j514c) are not indented relative to their
enum: keys, and the items sequence indicators (- enum:) are not indented
relative to the items: key.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-apple-t603x-initial-devices-v1-0-55b305833123@jannau.net?part=1