Re: [PATCH 09/11] dt-bindings: pwm: apple,s5l-fpwm: Add t6030 and t6031 compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between commit message body and patch contents. The commit message states it adds 'apple,t6030-pinctrl' and 'apple,t6031-pinctrl', but the patch actually adds 'apple,t6030-fpwm' and 'apple,t6031-fpwm'.
--

--- Patch [9]: [PATCH 09/11] dt-bindings: pwm: apple,s5l-fpwm: Add t6030 and t6031 compatibles ---
commit 311071f5987c86b8cc9cbb237a0d70bae746172d
Author: Janne Grunau <j@jannau.net>

dt-bindings: pwm: apple,s5l-fpwm: Add t6030 and t6031 compatibles

This commit adds new per-SoC compatible strings for the PWM controllers
on Apple silicon M3 Pro, Max, and Ultra SoCs.

> The PWM controller on Apple silicon M3 Pro, Max and Ultra SoCs is
> compatible with the t8103 (M1) one. Add "apple,t6030-pinctrl" for M3 Pro
> and "apple,t6031-pinctrl" for M3 Max and Ultra as per-SoC compatibles.

[Severity: Medium]
Is there a typo in the commit message description? The text mentions adding
"-pinctrl" compatibles ("apple,t6030-pinctrl" and "apple,t6031-pinctrl"),
but the patch itself actually adds "-fpwm" compatibles, which seems to be
the intended change for this file.

> diff --git a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
> index 25ef04b60ca17..dd95037ea5eef 100644
> --- a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
> @@ -21,6 +21,8 @@ properties:
>            - apple,t8122-fpwm
>            - apple,t6000-fpwm
>            - apple,t6020-fpwm
> +          - apple,t6030-fpwm
> +          - apple,t6031-fpwm
>        - const: apple,s5l-fpwm

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-apple-t603x-initial-devices-v1-0-55b305833123@jannau.net?part=9