Re: [PATCH 04/11] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing corresponding power state compatible strings in the child node binding `apple,pmgr-pwrstate.yaml`.
--

--- Patch [4]: [PATCH 04/11] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles ---
commit 70fb3d6202b1ab439abc072cacf0b78492449f42
Author: Janne Grunau <j@jannau.net>

dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

This commit adds per-SoC compatible strings for the Apple M3 Pro, Max, and
Ultra PMGR blocks to the apple,pmgr binding schema.

> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> index c67b67ba065af..1d2001836eb48 100644
> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> @@ -38,6 +38,8 @@ properties:
>        - items:
>            - enum:
>                - apple,t6020-pmgr
> +              - apple,t6030-pmgr
> +              - apple,t6031-pmgr

[Severity: Medium]
Since these new compatibles are being added here, do we also need to add
corresponding power state compatible strings to the child node binding?

Looking at Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
under properties:compatible:oneOf:items:enum, it lists:

      - items:
          - enum:
              - apple,t6020-pmgr-pwrstate
              - apple,t8122-pmgr-pwrstate
          - const: apple,t8103-pmgr-pwrstate

Will device tree schema validation fail for M3 Pro, Max, or Ultra device
trees that define power domain child nodes if apple,t6030-pmgr-pwrstate and
apple,t6031-pmgr-pwrstate are omitted from that enum?

>                - apple,t8122-pmgr
>            - const: apple,t8103-pmgr
>            - const: syscon

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-apple-t603x-initial-devices-v1-0-55b305833123@jannau.net?part=4