* [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog
@ 2016-10-16 10:49 Robert P. J. Day
2016-10-16 15:38 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2016-10-16 10:49 UTC (permalink / raw)
To: linux-watchdog
The word "legacy" should not be used for the special file
/dev/watchdog, as that file is still essential for watchdog
operations.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
i expressed my reservations about use of the word "legacy" here:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html
diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index 32930a0..0cc5ab8 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
* @wdd: watchdog device
* @devno: character device number
*
- * Register a watchdog character device including handling the legacy
+ * Register a watchdog character device including handling the
* /dev/watchdog node. /dev/watchdog is actually a miscdevice and
* thus we set it up like that.
*/
@@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
* watchdog_cdev_unregister: unregister watchdog character device
* @watchdog: watchdog device
*
- * Unregister watchdog character device and if needed the legacy
+ * Unregister watchdog character device and if needed the
* /dev/watchdog device.
*/
@@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
* watchdog_dev_register: register a watchdog device
* @wdd: watchdog device
*
- * Register a watchdog device including handling the legacy
+ * Register a watchdog device including handling the
* /dev/watchdog node. /dev/watchdog is actually a miscdevice and
* thus we set it up like that.
*/
@@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
* watchdog_dev_unregister: unregister a watchdog device
* @watchdog: watchdog device
*
- * Unregister watchdog device and if needed the legacy
+ * Unregister watchdog device and if needed the
* /dev/watchdog device.
*/
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog
2016-10-16 10:49 [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog Robert P. J. Day
@ 2016-10-16 15:38 ` Guenter Roeck
2016-10-16 15:41 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2016-10-16 15:38 UTC (permalink / raw)
To: Robert P. J. Day, linux-watchdog
On 10/16/2016 03:49 AM, Robert P. J. Day wrote:
> The word "legacy" should not be used for the special file
> /dev/watchdog, as that file is still essential for watchdog
> operations.
>
NAK. The non-legacy name is /dev/watchdog0.
Guenter
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> i expressed my reservations about use of the word "legacy" here:
>
> https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html
>
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index 32930a0..0cc5ab8 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
> * @wdd: watchdog device
> * @devno: character device number
> *
> - * Register a watchdog character device including handling the legacy
> + * Register a watchdog character device including handling the
> * /dev/watchdog node. /dev/watchdog is actually a miscdevice and
> * thus we set it up like that.
> */
> @@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
> * watchdog_cdev_unregister: unregister watchdog character device
> * @watchdog: watchdog device
> *
> - * Unregister watchdog character device and if needed the legacy
> + * Unregister watchdog character device and if needed the
> * /dev/watchdog device.
> */
>
> @@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
> * watchdog_dev_register: register a watchdog device
> * @wdd: watchdog device
> *
> - * Register a watchdog device including handling the legacy
> + * Register a watchdog device including handling the
> * /dev/watchdog node. /dev/watchdog is actually a miscdevice and
> * thus we set it up like that.
> */
> @@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
> * watchdog_dev_unregister: unregister a watchdog device
> * @watchdog: watchdog device
> *
> - * Unregister watchdog device and if needed the legacy
> + * Unregister watchdog device and if needed the
> * /dev/watchdog device.
> */
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog
2016-10-16 15:38 ` Guenter Roeck
@ 2016-10-16 15:41 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2016-10-16 15:41 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-watchdog
On Sun, 16 Oct 2016, Guenter Roeck wrote:
> On 10/16/2016 03:49 AM, Robert P. J. Day wrote:
> > The word "legacy" should not be used for the special file
> > /dev/watchdog, as that file is still essential for watchdog
> > operations.
> >
>
> NAK. The non-legacy name is /dev/watchdog0.
ah, that wasn't clear from the source file.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-16 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-16 10:49 [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog Robert P. J. Day
2016-10-16 15:38 ` Guenter Roeck
2016-10-16 15:41 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox