* [PATCH v3 0/2] watchdog: Don't use "proxy" inclusions
@ 2025-07-08 13:33 Andy Shevchenko
2025-07-08 13:33 ` [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers Andy Shevchenko
2025-07-08 13:33 ` [PATCH v3 2/2] watchdog: " Andy Shevchenko
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2025-07-08 13:33 UTC (permalink / raw)
To: Guenter Roeck, James Hilliard, Wolfram Sang, Andy Shevchenko,
linux-watchdog, linux-kernel
Cc: Wim Van Sebroeck
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Changelog v3:
- added prerequisite to avoid compilation errors (LKP, Guenter)
Andy Shevchenko (2):
watchdog: it87_wdt: Don't use "proxy" headers
watchdog: Don't use "proxy" headers
drivers/watchdog/it87_wdt.c | 4 +++-
drivers/watchdog/watchdog_core.h | 8 +++++++-
drivers/watchdog/watchdog_pretimeout.c | 2 ++
include/linux/watchdog.h | 12 ++++++++----
4 files changed, 20 insertions(+), 6 deletions(-)
--
2.47.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers
2025-07-08 13:33 [PATCH v3 0/2] watchdog: Don't use "proxy" inclusions Andy Shevchenko
@ 2025-07-08 13:33 ` Andy Shevchenko
2025-07-17 0:24 ` Guenter Roeck
2025-07-08 13:33 ` [PATCH v3 2/2] watchdog: " Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2025-07-08 13:33 UTC (permalink / raw)
To: Guenter Roeck, James Hilliard, Wolfram Sang, Andy Shevchenko,
linux-watchdog, linux-kernel
Cc: Wim Van Sebroeck
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/watchdog/it87_wdt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
index a1e23dce8810..3b8488c86a2f 100644
--- a/drivers/watchdog/it87_wdt.c
+++ b/drivers/watchdog/it87_wdt.c
@@ -22,11 +22,13 @@
#include <linux/bits.h>
#include <linux/dmi.h>
+#include <linux/errno.h>
#include <linux/init.h>
#include <linux/io.h>
-#include <linux/kernel.h>
+#include <linux/ioport.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
+#include <linux/printk.h>
#include <linux/types.h>
#include <linux/watchdog.h>
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers
2025-07-08 13:33 ` [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers Andy Shevchenko
@ 2025-07-17 0:24 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2025-07-17 0:24 UTC (permalink / raw)
To: Andy Shevchenko, James Hilliard, Wolfram Sang, linux-watchdog,
linux-kernel
Cc: Wim Van Sebroeck
On 7/8/25 06:33, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it87_wdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index a1e23dce8810..3b8488c86a2f 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -22,11 +22,13 @@
>
> #include <linux/bits.h>
> #include <linux/dmi.h>
> +#include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/ioport.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> +#include <linux/printk.h>
> #include <linux/types.h>
> #include <linux/watchdog.h>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] watchdog: Don't use "proxy" headers
2025-07-08 13:33 [PATCH v3 0/2] watchdog: Don't use "proxy" inclusions Andy Shevchenko
2025-07-08 13:33 ` [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers Andy Shevchenko
@ 2025-07-08 13:33 ` Andy Shevchenko
2025-07-17 0:25 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2025-07-08 13:33 UTC (permalink / raw)
To: Guenter Roeck, James Hilliard, Wolfram Sang, Andy Shevchenko,
linux-watchdog, linux-kernel
Cc: Wim Van Sebroeck
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/watchdog/watchdog_core.h | 8 +++++++-
drivers/watchdog/watchdog_pretimeout.c | 2 ++
include/linux/watchdog.h | 12 ++++++++----
3 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/watchdog_core.h b/drivers/watchdog/watchdog_core.h
index 5b35a8439e26..ab825d9f9248 100644
--- a/drivers/watchdog/watchdog_core.h
+++ b/drivers/watchdog/watchdog_core.h
@@ -24,8 +24,14 @@
* This material is provided "AS-IS" and at no charge.
*/
-#include <linux/hrtimer.h>
+#include <linux/cdev.h>
+#include <linux/device.h>
+#include <linux/hrtimer_types.h>
+#include <linux/init.h>
#include <linux/kthread.h>
+#include <linux/mutex_types.h>
+#include <linux/types.h>
+#include <linux/watchdog.h>
#define MAX_DOGS 32 /* Maximum number of watchdog devices */
diff --git a/drivers/watchdog/watchdog_pretimeout.c b/drivers/watchdog/watchdog_pretimeout.c
index e5295c990fa1..2526436dc74d 100644
--- a/drivers/watchdog/watchdog_pretimeout.c
+++ b/drivers/watchdog/watchdog_pretimeout.c
@@ -7,6 +7,8 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/string.h>
+#include <linux/sysfs.h>
+#include <linux/types.h>
#include <linux/watchdog.h>
#include "watchdog_core.h"
diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
index 99660197a36c..8c60687a3e55 100644
--- a/include/linux/watchdog.h
+++ b/include/linux/watchdog.h
@@ -9,14 +9,18 @@
#ifndef _LINUX_WATCHDOG_H
#define _LINUX_WATCHDOG_H
-
#include <linux/bitops.h>
-#include <linux/cdev.h>
-#include <linux/device.h>
-#include <linux/kernel.h>
+#include <linux/limits.h>
#include <linux/notifier.h>
+#include <linux/printk.h>
+#include <linux/types.h>
+
#include <uapi/linux/watchdog.h>
+struct attribute_group;
+struct device;
+struct module;
+
struct watchdog_ops;
struct watchdog_device;
struct watchdog_core_data;
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] watchdog: Don't use "proxy" headers
2025-07-08 13:33 ` [PATCH v3 2/2] watchdog: " Andy Shevchenko
@ 2025-07-17 0:25 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2025-07-17 0:25 UTC (permalink / raw)
To: Andy Shevchenko, James Hilliard, Wolfram Sang, linux-watchdog,
linux-kernel
Cc: Wim Van Sebroeck
On 7/8/25 06:33, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/watchdog_core.h | 8 +++++++-
> drivers/watchdog/watchdog_pretimeout.c | 2 ++
> include/linux/watchdog.h | 12 ++++++++----
> 3 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/watchdog_core.h b/drivers/watchdog/watchdog_core.h
> index 5b35a8439e26..ab825d9f9248 100644
> --- a/drivers/watchdog/watchdog_core.h
> +++ b/drivers/watchdog/watchdog_core.h
> @@ -24,8 +24,14 @@
> * This material is provided "AS-IS" and at no charge.
> */
>
> -#include <linux/hrtimer.h>
> +#include <linux/cdev.h>
> +#include <linux/device.h>
> +#include <linux/hrtimer_types.h>
> +#include <linux/init.h>
> #include <linux/kthread.h>
> +#include <linux/mutex_types.h>
> +#include <linux/types.h>
> +#include <linux/watchdog.h>
>
> #define MAX_DOGS 32 /* Maximum number of watchdog devices */
>
> diff --git a/drivers/watchdog/watchdog_pretimeout.c b/drivers/watchdog/watchdog_pretimeout.c
> index e5295c990fa1..2526436dc74d 100644
> --- a/drivers/watchdog/watchdog_pretimeout.c
> +++ b/drivers/watchdog/watchdog_pretimeout.c
> @@ -7,6 +7,8 @@
> #include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <linux/string.h>
> +#include <linux/sysfs.h>
> +#include <linux/types.h>
> #include <linux/watchdog.h>
>
> #include "watchdog_core.h"
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 99660197a36c..8c60687a3e55 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -9,14 +9,18 @@
> #ifndef _LINUX_WATCHDOG_H
> #define _LINUX_WATCHDOG_H
>
> -
> #include <linux/bitops.h>
> -#include <linux/cdev.h>
> -#include <linux/device.h>
> -#include <linux/kernel.h>
> +#include <linux/limits.h>
> #include <linux/notifier.h>
> +#include <linux/printk.h>
> +#include <linux/types.h>
> +
> #include <uapi/linux/watchdog.h>
>
> +struct attribute_group;
> +struct device;
> +struct module;
> +
> struct watchdog_ops;
> struct watchdog_device;
> struct watchdog_core_data;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-17 0:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08 13:33 [PATCH v3 0/2] watchdog: Don't use "proxy" inclusions Andy Shevchenko
2025-07-08 13:33 ` [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers Andy Shevchenko
2025-07-17 0:24 ` Guenter Roeck
2025-07-08 13:33 ` [PATCH v3 2/2] watchdog: " Andy Shevchenko
2025-07-17 0:25 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox