From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] hostapd: don't try setting the generic IE to the kernel
Date: Wed, 26 Sep 2007 14:54:18 +0200 [thread overview]
Message-ID: <1190811258.4204.7.camel@johannes.berg> (raw)
We have no mac80211 drivers that generate beacons themselves
and would require this, and we also have no way to support such
drivers currently. Hence, it seems we should remove this to
decrease the confusion. Since the generic hostapd code actually
requires a positive result though we cannot just remove the
implementation. The same information is put into the beacon,
however.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
hostapd/driver_devicescape.c | 14 --------------
1 file changed, 14 deletions(-)
--- hostap.orig/hostapd/driver_devicescape.c 2007-09-26 14:45:22.000000000 +0200
+++ hostap/hostapd/driver_devicescape.c 2007-09-26 14:47:17.000000000 +0200
@@ -695,20 +695,6 @@ static int i802_sta_set_flags(void *priv
static int i802_set_generic_elem(const char *ifname, void *priv,
const u8 *elem, size_t elem_len)
{
- struct i802_driver_data *drv = priv;
- struct iwreq iwr;
-
- memset(&iwr, 0, sizeof(iwr));
-
- os_strlcpy(iwr.ifr_name, drv->hapd->conf->iface, IFNAMSIZ);
- iwr.u.data.length = elem_len;
- iwr.u.data.pointer = (void*)elem;
-
- if (ioctl(drv->ioctl_sock, SIOCSIWGENIE, &iwr) < 0) {
- perror("Failed to set generic info element");
- return -1;
- }
-
return 0;
}
next reply other threads:[~2007-09-26 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 12:54 Johannes Berg [this message]
2007-10-03 3:01 ` [PATCH] hostapd: don't try setting the generic IE to the kernel Jouni Malinen
2007-10-03 6:47 ` Johannes Berg
2007-10-04 4:12 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190811258.4204.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox