From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] hostapd: don't try setting the generic IE to the kernel
Date: Wed, 3 Oct 2007 21:12:27 -0700 [thread overview]
Message-ID: <20071004041227.GN933@jm.kir.nu> (raw)
In-Reply-To: <1191394054.4178.2.camel@johannes.berg>
On Wed, Oct 03, 2007 at 08:47:34AM +0200, Johannes Berg wrote:
> On Tue, 2007-10-02 at 20:01 -0700, Jouni Malinen wrote:
> > hostapd_set_generic_elem() wrapper for this driver wrapper function
> > should return 0 if the wrapper is not implemented (function pointer is
> > NULL).. Did I miss something or shouldn't we just remove
> > i802_set_generic_elem() function completely instead of leaving the empty
> > "return 0" version in?
>
> Oh no you're right, somehow I was under the impression that the wrapper
> function returned an error if it wasn't implemented. Want a new patch?
No need for a new patch; I applied your patch with a modification of
jusr removing the function completely.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2007-10-04 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 12:54 [PATCH] hostapd: don't try setting the generic IE to the kernel Johannes Berg
2007-10-03 3:01 ` Jouni Malinen
2007-10-03 6:47 ` Johannes Berg
2007-10-04 4:12 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004041227.GN933@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox