From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] hostapd: don't try setting the generic IE to the kernel
Date: Tue, 2 Oct 2007 20:01:50 -0700 [thread overview]
Message-ID: <20071003030150.GG933@jm.kir.nu> (raw)
In-Reply-To: <1190811258.4204.7.camel@johannes.berg>
On Wed, Sep 26, 2007 at 02:54:18PM +0200, Johannes Berg wrote:
> We have no mac80211 drivers that generate beacons themselves
> and would require this, and we also have no way to support such
> drivers currently. Hence, it seems we should remove this to
> decrease the confusion. Since the generic hostapd code actually
> requires a positive result though we cannot just remove the
> implementation. The same information is put into the beacon,
> however.
hostapd_set_generic_elem() wrapper for this driver wrapper function
should return 0 if the wrapper is not implemented (function pointer is
NULL).. Did I miss something or shouldn't we just remove
i802_set_generic_elem() function completely instead of leaving the empty
"return 0" version in?
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2007-10-03 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 12:54 [PATCH] hostapd: don't try setting the generic IE to the kernel Johannes Berg
2007-10-03 3:01 ` Jouni Malinen [this message]
2007-10-03 6:47 ` Johannes Berg
2007-10-04 4:12 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003030150.GG933@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox