Re: [PATCH] mac80211: don't use interface indizes

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]


> That's a pretty terrible name. mac80211 is not a valid prefix to be used in 
> the codebase, at least not for structures and functions. Everything else uses 
> ieee80211 so use of mac80211 is not acceptable, especially for driver facing 
> API. (the use of that prefix in event.c isn't right either.. need to fix 
> that)

Heh. True, I'll s/mac80211_vif/ieee80211_vif/

> Leaving it to the driver to allocate the private space isn't too great either. 
> Something like a char subif_priv[] at the end of ieee80211_sub_if_data and a 
> way to specify the length of the private area will be more useful to drivers 
> which wish to use the per-subif private space by avoiding extra allocation 
> and allocation failure handling and also for drivers which don't, by 
> eliminating the overhead of storing an unused pointer. It is also more 
> consistent with the other apis that allocate ieee80211_hw and net_device.

Most drivers won't ever need private space, so leaving it to them to
allocate is more efficient.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]