Re: [PATCH] mac80211: don't use interface indizes

[Michael Wu <flamingice@sourmilk.net>]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

On Tuesday 04 December 2007 10:40:30 Johannes Berg wrote:
> This patch gets rid of the if_id stuff all over in favour of a new
> virtual-interface structure "struct mac80211_vif".
That's a pretty terrible name. mac80211 is not a valid prefix to be used in 
the codebase, at least not for structures and functions. Everything else uses 
ieee80211 so use of mac80211 is not acceptable, especially for driver facing 
API. (the use of that prefix in event.c isn't right either.. need to fix 
that)

Leaving it to the driver to allocate the private space isn't too great either. 
Something like a char subif_priv[] at the end of ieee80211_sub_if_data and a 
way to specify the length of the private area will be more useful to drivers 
which wish to use the per-subif private space by avoiding extra allocation 
and allocation failure handling and also for drivers which don't, by 
eliminating the overhead of storing an unused pointer. It is also more 
consistent with the other apis that allocate ieee80211_hw and net_device.

> Only compile-tested the driver changes, sanity checks required.
>
There you go. ;)

-Michael Wu

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]