Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: jt@hpl.hp.com, linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [RFC PATCH] introduce WEXT scan capabilities
Date: Sun, 09 Dec 2007 12:35:06 -0500	[thread overview]
Message-ID: <1197221706.9149.36.camel@localhost.localdomain> (raw)
In-Reply-To: <20071207.180408.55119728.davem@davemloft.net>

On Fri, 2007-12-07 at 18:04 -0800, David Miller wrote:
> From: Jean Tourrilhes <jt@hpl.hp.com>
> Date: Fri, 7 Dec 2007 11:27:56 -0800
> 
> > > Can you explain a bit more about this patch?
> > 
> > 	Those fields are defined and used in userspace, please check
> > wireless.21.h in Wireless Tools.
> 
> If you need auxiliary data in the userspace application, define
> an auxiliary structure which references the thing you get back
> from the kernel.
> 
> I totally disagree with embedding things in kernel defined
> interfaces that are purely userland internal data structures.
> 
> You really need to clean up the way you handle the wireless
> kernel APIs, it is getting worse not better and you really
> do not use good judgment or good interface design practices
> when you makes these changes.
> 
> Everything is one big hack.
> 
> I will seriously NACK wireless API changes like this until
> the situation starts to improve.

So how would _you_ add a scan capabilities bitfield (or a new generic
capabilities bitfield) to the WEXT range call?

We need the scan capability flag functionality; I don't care how we get
it as long as the patch is not too invasive.  But userspace needs to
know what the driver can do, and the patch needs to be written so that
drivers that don't have the capabilities don't need to be touched.

Dan



  reply	other threads:[~2007-12-09 17:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 11:28 [RFC PATCH] introduce WEXT scan capabilities Dan Williams
2007-12-06 19:11 ` Jean Tourrilhes
2007-12-07 10:20   ` Dan Williams
2007-12-07 19:27     ` Jean Tourrilhes
2007-12-07 21:38       ` Johannes Berg
2007-12-07 22:19         ` Jean Tourrilhes
2007-12-07 22:27           ` Johannes Berg
2007-12-08  2:04       ` David Miller
2007-12-09 17:35         ` Dan Williams [this message]
2007-12-09 17:59           ` Dan Williams
2007-12-10  6:10             ` David Miller
2007-12-10 17:23               ` Dan Williams
2007-12-11  0:11                 ` David Miller
2007-12-11  4:22                   ` Dan Williams
2007-12-11  4:51                     ` David Miller
2007-12-11 15:01                       ` Dan Williams
2007-12-10 12:15             ` Johannes Berg
2007-12-10 18:09               ` Jean Tourrilhes
2007-12-11  0:15                 ` David Miller
2007-12-11 13:21                 ` Johannes Berg
2007-12-10 18:11           ` Jean Tourrilhes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197221706.9149.36.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=jt@hpl.hp.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox