From: David Miller <davem@davemloft.net>
To: jt@hpl.hp.com
Cc: dcbw@redhat.com, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net
Subject: Re: [RFC PATCH] introduce WEXT scan capabilities
Date: Fri, 07 Dec 2007 18:04:08 -0800 (PST) [thread overview]
Message-ID: <20071207.180408.55119728.davem@davemloft.net> (raw)
In-Reply-To: <20071207192756.GA15864@bougret.hpl.hp.com>
From: Jean Tourrilhes <jt@hpl.hp.com>
Date: Fri, 7 Dec 2007 11:27:56 -0800
> > Can you explain a bit more about this patch?
>
> Those fields are defined and used in userspace, please check
> wireless.21.h in Wireless Tools.
If you need auxiliary data in the userspace application, define
an auxiliary structure which references the thing you get back
from the kernel.
I totally disagree with embedding things in kernel defined
interfaces that are purely userland internal data structures.
You really need to clean up the way you handle the wireless
kernel APIs, it is getting worse not better and you really
do not use good judgment or good interface design practices
when you makes these changes.
Everything is one big hack.
I will seriously NACK wireless API changes like this until
the situation starts to improve.
next prev parent reply other threads:[~2007-12-08 2:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 11:28 [RFC PATCH] introduce WEXT scan capabilities Dan Williams
2007-12-06 19:11 ` Jean Tourrilhes
2007-12-07 10:20 ` Dan Williams
2007-12-07 19:27 ` Jean Tourrilhes
2007-12-07 21:38 ` Johannes Berg
2007-12-07 22:19 ` Jean Tourrilhes
2007-12-07 22:27 ` Johannes Berg
2007-12-08 2:04 ` David Miller [this message]
2007-12-09 17:35 ` Dan Williams
2007-12-09 17:59 ` Dan Williams
2007-12-10 6:10 ` David Miller
2007-12-10 17:23 ` Dan Williams
2007-12-11 0:11 ` David Miller
2007-12-11 4:22 ` Dan Williams
2007-12-11 4:51 ` David Miller
2007-12-11 15:01 ` Dan Williams
2007-12-10 12:15 ` Johannes Berg
2007-12-10 18:09 ` Jean Tourrilhes
2007-12-11 0:15 ` David Miller
2007-12-11 13:21 ` Johannes Berg
2007-12-10 18:11 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207.180408.55119728.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=jt@hpl.hp.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox