From: David Miller <davem@davemloft.net>
To: jt@hpl.hp.com
Cc: johannes@sipsolutions.net, dcbw@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] introduce WEXT scan capabilities
Date: Mon, 10 Dec 2007 16:15:04 -0800 (PST) [thread overview]
Message-ID: <20071210.161504.159685695.davem@davemloft.net> (raw)
In-Reply-To: <20071210180921.GB7168@bougret.hpl.hp.com>
From: Jean Tourrilhes <jt@hpl.hp.com>
Date: Mon, 10 Dec 2007 10:09:21 -0800
> On Mon, Dec 10, 2007 at 01:15:27PM +0100, Johannes Berg wrote:
> >
> > > Do either of those sound better to you than extending struct iw_range?
> >
> > Because wext is stupidly defined, you can never extend any structures it
> > uses. Wext never passes in the length that userspace expects to passing
> > in longer structures than the fixed one userspace expects will always
> > overwrite something in userspace, possibly on the stack.
> >
> > johannes
>
> Please check again...
I've personally already fixed a bug like this for 64-bit because the
WEXT request struct is smaller than an ifreq and the former is what
the applications declare on the stack yet an ifreq is what was used to
size to copy back into userspace.
There are therefore definitely past and potential future problems in
this area, and indeed it is a design issue.
next prev parent reply other threads:[~2007-12-11 0:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 11:28 [RFC PATCH] introduce WEXT scan capabilities Dan Williams
2007-12-06 19:11 ` Jean Tourrilhes
2007-12-07 10:20 ` Dan Williams
2007-12-07 19:27 ` Jean Tourrilhes
2007-12-07 21:38 ` Johannes Berg
2007-12-07 22:19 ` Jean Tourrilhes
2007-12-07 22:27 ` Johannes Berg
2007-12-08 2:04 ` David Miller
2007-12-09 17:35 ` Dan Williams
2007-12-09 17:59 ` Dan Williams
2007-12-10 6:10 ` David Miller
2007-12-10 17:23 ` Dan Williams
2007-12-11 0:11 ` David Miller
2007-12-11 4:22 ` Dan Williams
2007-12-11 4:51 ` David Miller
2007-12-11 15:01 ` Dan Williams
2007-12-10 12:15 ` Johannes Berg
2007-12-10 18:09 ` Jean Tourrilhes
2007-12-11 0:15 ` David Miller [this message]
2007-12-11 13:21 ` Johannes Berg
2007-12-10 18:11 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210.161504.159685695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=jt@hpl.hp.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox