From: Johannes Berg <johannes@sipsolutions.net>
To: Ron Rindjunsky <ron.rindjunsky@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
flamingice@sourmilk.net, tomas.winkler@intel.com,
yi.zhu@intel.com
Subject: Re: [PATCH 2/8] mac80211: A-MPDU Rx add MLME structures
Date: Tue, 18 Dec 2007 22:18:12 +0100 [thread overview]
Message-ID: <1198012693.4885.180.camel@johannes.berg> (raw)
In-Reply-To: <c85cb4470712180541l3427454ek94c66b14bb26cb4f@mail.gmail.com> (sfid-20071218_134145_320212_A4A350F5)
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Tue, 2007-12-18 at 15:41 +0200, Ron Rindjunsky wrote:
> >
> > > + struct sta_ampdu_mlme ampdu_mlme;
> > > + int timer_to_tid[STA_TID_NUM]; /* convert timer id to tid */
> >
> > Since you only use that as an identity mapping it can well be a u8
> > array. Not that I like the trick used, but I don't see any good way to
> > avoid it either.
> >
>
> yes... that was quite an irritating issue, had to use this kind of
> mechanism here.
> i will check changing type to u8 (need to exmine if it will cause any
> addresses problems)
I just checked, it's an unsigned long and not an address so you can
really pass anything to it. Therefore, I think using a u8 array would be
appropriate.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-12-19 15:45 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 15:57 [PATCH 0/8] mac80211/iwlwifi: integrate IEEE802.11n A-MPDU Rx MLME Ron Rindjunsky
2007-12-17 15:57 ` [PATCH 1/8] mac80211: A-MPDU Rx add low level driver API Ron Rindjunsky
2007-12-17 17:54 ` Johannes Berg
2007-12-17 22:38 ` Johannes Berg
2007-12-18 13:41 ` Ron Rindjunsky
2007-12-18 14:01 ` Johannes Berg
2007-12-17 15:57 ` [PATCH 2/8] mac80211: A-MPDU Rx add MLME structures Ron Rindjunsky
2007-12-17 18:08 ` Johannes Berg
2007-12-18 13:41 ` Ron Rindjunsky
2007-12-18 13:59 ` Johannes Berg
2007-12-18 21:18 ` Johannes Berg [this message]
2007-12-19 18:59 ` Rindjunsky, Ron
2007-12-17 15:57 ` [PATCH 3/8] mac80211: A-MPDU Rx adding basic functionality Ron Rindjunsky
2007-12-17 18:06 ` Johannes Berg
2007-12-18 13:42 ` Ron Rindjunsky
2007-12-17 15:57 ` [PATCH 4/8] mac80211: A-MPDU Rx MLME data initialization Ron Rindjunsky
2007-12-17 18:09 ` Johannes Berg
2007-12-18 13:43 ` Ron Rindjunsky
2007-12-17 15:57 ` [PATCH 5/8] mac80211: A-MPDU Rx handling aggregation reordering Ron Rindjunsky
2007-12-17 18:18 ` Johannes Berg
2007-12-18 13:44 ` Ron Rindjunsky
2007-12-18 13:57 ` Johannes Berg
2007-12-19 10:57 ` Rindjunsky, Ron
2007-12-19 15:47 ` Johannes Berg
2007-12-19 16:29 ` Winkler, Tomas
2007-12-19 16:36 ` Johannes Berg
2007-12-20 10:14 ` Johannes Berg
2007-12-20 12:32 ` Ron Rindjunsky
2007-12-20 12:41 ` Johannes Berg
2007-12-20 14:15 ` Ron Rindjunsky
2007-12-23 16:15 ` Ron Rindjunsky
2007-12-23 17:28 ` Johannes Berg
2007-12-23 17:38 ` Ron Rindjunsky
2007-12-23 18:15 ` Johannes Berg
2007-12-17 15:57 ` [PATCH 6/8] mac80211: A-MPDU Rx adding BAR handling capability Ron Rindjunsky
2007-12-17 18:24 ` Johannes Berg
2007-12-18 13:45 ` Ron Rindjunsky
2007-12-18 13:53 ` Johannes Berg
2007-12-19 13:25 ` Rindjunsky, Ron
2007-12-19 15:45 ` Johannes Berg
2007-12-19 18:59 ` Rindjunsky, Ron
2007-12-17 15:57 ` [PATCH 7/8] mac80211: A-MPDU Rx handling DELBA requests Ron Rindjunsky
2007-12-17 18:26 ` Johannes Berg
2007-12-18 13:46 ` Ron Rindjunsky
2007-12-18 13:51 ` Johannes Berg
2007-12-19 13:22 ` Rindjunsky, Ron
2007-12-17 15:57 ` [PATCH 8/8] iwlwifi: A-MPDU Rx flow enabled Ron Rindjunsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198012693.4885.180.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox