From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: proper monitor support
Date: Wed, 19 Dec 2007 16:50:04 +0100 [thread overview]
Message-ID: <1198079405.4747.13.camel@johannes.berg> (raw)
In-Reply-To: <1198052938-25637-1-git-send-email-yi.zhu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Wed, 2007-12-19 at 16:28 +0800, Zhu Yi wrote:
> This patch changes the iwlwifi driver to properly support
> monitor interfaces after the filter flags change.
>
> The patch is originally created by Johannes Berg for iwl4965. I fixed some
> of the comments and created a similar patch for iwl3945.
Looks good, thanks.
> + /*
> + * We won't receive HT frames in monitor mode. For legacy frames, we do * have enough headroom here.
> + */
You lost a newline there. Also, I don't think that is true. With
mac80211's virtual interfaces, you can have monitor interfaces while
operating regularly as a sta mode interface.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-12-19 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 8:28 [PATCH] iwlwifi: proper monitor support Zhu Yi
2007-12-19 15:50 ` Johannes Berg [this message]
2007-12-20 0:04 ` Tomas Winkler
2007-12-20 0:08 ` Tomas Winkler
2007-12-20 3:15 ` Zhu Yi
2007-12-20 3:22 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198079405.4747.13.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox