Re: [PATCH] iwlwifi: proper monitor support

["Tomas Winkler" <tomasw@gmail.com>]

On Dec 20, 2007 2:04 AM, Tomas Winkler <tomasw@gmail.com> wrote:
> On Dec 19, 2007 10:28 AM, Zhu Yi <yi.zhu@intel.com> wrote:
> > This patch changes the iwlwifi driver to properly support
> > monitor interfaces after the filter flags change.
> >
> > The patch is originally created by Johannes Berg for iwl4965. I fixed some
> > of the comments and created a similar patch for iwl3945.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> > ---
> >  drivers/net/wireless/iwlwifi/iwl-3945.c     |  118 ++++++++++++++++++++++----
> >  drivers/net/wireless/iwlwifi/iwl-3945.h     |   36 +++------
> >  drivers/net/wireless/iwlwifi/iwl-4965.c     |  120 ++++++++++++++++++++++++--
> >  drivers/net/wireless/iwlwifi/iwl-4965.h     |   24 +-----
> >  drivers/net/wireless/iwlwifi/iwl3945-base.c |  109 +++----------------------
> >  drivers/net/wireless/iwlwifi/iwl4965-base.c |   90 +--------------------
> >  6 files changed, 236 insertions(+), 261 deletions(-)
> >
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> > index 7d15b33..07fa363 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> > @@ -35,9 +35,9 @@
> >
> > +static void iwl4965_add_radiotap(struct iwl4965_priv *priv,
> > +                                struct sk_buff *skb,
> > +                                struct iwl4965_rx_phy_res *rx_start,
> > +                                struct ieee80211_rx_status *stats,
> > +                                u32 ampdu_status)
> > +{
> > +       s8 signal = stats->ssi;
> > +       s8 noise = 0;
> > +       int rate = stats->rate;
> > +       u64 tsf = stats->mactime;
> > +       __le16 phy_flags_hw = rx_start->phy_flags;
> > +       struct iwl4965_rt_rx_hdr {
> > +               struct ieee80211_radiotap_header rt_hdr;
> > +               __le64 rt_tsf;          /* TSF */
> > +               u8 rt_flags;            /* radiotap packet flags */
> > +               u8 rt_rate;             /* rate in 500kb/s */
>
> You probably wants to have u32 value to accommodate HT rates (MCS)

I've made a mistake this is not logical but actual rate so it
theoretically we can go up to 600Mbs so it will make it 120 < 256.
But aren't we interested in MSC rate a packet was sent?

> > +               __le16 rt_channelMHz;   /* channel in MHz */
>
> > +               __le16 rt_chbitmask;    /* channel bitfield */
> > +               s8 rt_dbmsignal;        /* signal in dBm, kluged to signed */
> > +               s8 rt_dbmnoise;
> > +               u8 rt_antenna;          /* antenna number */
> > +       } __attribute__ ((packed)) *iwl4965_rt;
> > +
> > +       /*
> Tomas
>