From: "Tomas Winkler" <tomasw@gmail.com>
To: "Zhu Yi" <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
"Johannes Berg" <johannes@sipsolutions.net>
Subject: Re: [PATCH] iwlwifi: proper monitor support
Date: Thu, 20 Dec 2007 02:04:36 +0200 [thread overview]
Message-ID: <1ba2fa240712191604l1f5343c0s62e66aaf2077cce1@mail.gmail.com> (raw)
In-Reply-To: <1198052938-25637-1-git-send-email-yi.zhu@intel.com>
On Dec 19, 2007 10:28 AM, Zhu Yi <yi.zhu@intel.com> wrote:
> This patch changes the iwlwifi driver to properly support
> monitor interfaces after the filter flags change.
>
> The patch is originally created by Johannes Berg for iwl4965. I fixed some
> of the comments and created a similar patch for iwl3945.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-3945.c | 118 ++++++++++++++++++++++----
> drivers/net/wireless/iwlwifi/iwl-3945.h | 36 +++------
> drivers/net/wireless/iwlwifi/iwl-4965.c | 120 ++++++++++++++++++++++++--
> drivers/net/wireless/iwlwifi/iwl-4965.h | 24 +-----
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 109 +++----------------------
> drivers/net/wireless/iwlwifi/iwl4965-base.c | 90 +--------------------
> 6 files changed, 236 insertions(+), 261 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 7d15b33..07fa363 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -35,9 +35,9 @@
>
> +static void iwl4965_add_radiotap(struct iwl4965_priv *priv,
> + struct sk_buff *skb,
> + struct iwl4965_rx_phy_res *rx_start,
> + struct ieee80211_rx_status *stats,
> + u32 ampdu_status)
> +{
> + s8 signal = stats->ssi;
> + s8 noise = 0;
> + int rate = stats->rate;
> + u64 tsf = stats->mactime;
> + __le16 phy_flags_hw = rx_start->phy_flags;
> + struct iwl4965_rt_rx_hdr {
> + struct ieee80211_radiotap_header rt_hdr;
> + __le64 rt_tsf; /* TSF */
> + u8 rt_flags; /* radiotap packet flags */
> + u8 rt_rate; /* rate in 500kb/s */
You probably wants to have u32 value to accommodate HT rates (MCS)
> + __le16 rt_channelMHz; /* channel in MHz */
> + __le16 rt_chbitmask; /* channel bitfield */
> + s8 rt_dbmsignal; /* signal in dBm, kluged to signed */
> + s8 rt_dbmnoise;
> + u8 rt_antenna; /* antenna number */
> + } __attribute__ ((packed)) *iwl4965_rt;
> +
> + /*
Tomas
next prev parent reply other threads:[~2007-12-20 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 8:28 [PATCH] iwlwifi: proper monitor support Zhu Yi
2007-12-19 15:50 ` Johannes Berg
2007-12-20 0:04 ` Tomas Winkler [this message]
2007-12-20 0:08 ` Tomas Winkler
2007-12-20 3:15 ` Zhu Yi
2007-12-20 3:22 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240712191604l1f5343c0s62e66aaf2077cce1@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox