From: Johannes Berg <johannes@sipsolutions.net>
To: Ron Rindjunsky <ron.rindjunsky@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
flamingice@sourmilk.net, tomas.winkler@intel.com,
yi.zhu@intel.com
Subject: Re: [PATCH 05/12] mac80211: A-MPDU add debugfs support
Date: Thu, 24 Jan 2008 10:45:52 +0100 [thread overview]
Message-ID: <1201167952.3454.79.camel@johannes.berg> (raw)
In-Reply-To: <12009163391538-git-send-email-ron.rindjunsky@intel.com> (sfid-20080121_115442_600581_DD9FB5B9)
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
> + if ((tid_num >= 100) && (tid_num <= 115)) {
> + /* toggle Rx aggregation command */
I think that's a bit odd, but I guess everything else is more work.
> + printk(KERN_ERR "%s tried switching tid=%u %s\n", __func__,
> + tid_num, state);
> + printk(KERN_ERR "%s tried switching tid=%u %s, return=%d\n",
> + __func__, tid_num, state, rs);
KERN_ERR is a bit excessive, don't you think?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-01-24 14:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 11:52 [PATCH 0/12] mac80211/iwlwifi: A-MPDU Tx support Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 01/12] mac80211: A-MPDU Tx add session's and low level driver's API Ron Rindjunsky
2008-01-24 9:23 ` Johannes Berg
2008-01-27 17:24 ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 02/12] mac80211: A-MPDU Tx add MLME structures Ron Rindjunsky
2008-01-24 9:29 ` Johannes Berg
2008-01-27 17:25 ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 03/12] mac80211: A-MPDU Tx adding basic functionality Ron Rindjunsky
2008-01-24 9:30 ` Johannes Berg
2008-01-27 17:25 ` Ron Rindjunsky
2008-01-24 9:34 ` Johannes Berg
2008-01-27 17:25 ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 04/12] mac80211: A-MPDU Tx MLME data initialization Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 05/12] mac80211: A-MPDU add debugfs support Ron Rindjunsky
2008-01-24 9:45 ` Johannes Berg [this message]
2008-01-21 11:52 ` [PATCH 06/12] mac80211: A-MPDU Tx adding qdisc support Ron Rindjunsky
2008-01-24 9:42 ` Johannes Berg
2008-01-27 17:26 ` Ron Rindjunsky
2008-01-29 16:12 ` Johannes Berg
2008-01-30 9:11 ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 07/12] mac80211: A-MPDU Tx change tx_status to support Block Ack data Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 08/12] mac80211: A-MPDU Tx add delBA from recipient support Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 09/12] iwlwifi: A-MPDU Tx conform API to mac80211 Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 10/12] iwlwifi: A-MPDU Tx conform flows " Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 11/12] iwlwifi: A-MPDU Tx conform block Ack rate scaling " Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 12/12] wlwifi: A-MPDU Tx activation by load measures Ron Rindjunsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201167952.3454.79.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox