Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Ron Rindjunsky" <rindjon@googlemail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	flamingice@sourmilk.net, tomas.winkler@intel.com,
	yi.zhu@intel.com
Subject: Re: [PATCH 01/12] mac80211: A-MPDU Tx add session's and low level driver's API
Date: Sun, 27 Jan 2008 19:24:57 +0200	[thread overview]
Message-ID: <c85cb4470801270924n647e83f4s6ac56154ef36dee8@mail.gmail.com> (raw)
In-Reply-To: <1201166631.3454.57.camel@johannes.berg>

> >       int (*ampdu_action)(struct ieee80211_hw *hw,
> >                           enum ieee80211_ampdu_mlme_action action,
> > -                         const u8 *ra, u16 tid, u16 ssn);
> > +                         u8 *addr, u16 tid, u16 *ssn);
>
> Any reason you're removing the "const"?
>
> > +int ieee80211_start_tx_ba_session(struct ieee80211_hw *hw, u8 *ra, u16 tid);
>
> Maybe the other functions should instead use a const u8 *ra?
>

just because this touches many functions I'll check if this can be
done easily. even if not i can change it, leave a warning for const
type, and do a patch on top of this series to fix it.

> I don't have much to say about this patch really :)
>
> johannes
>
>

  reply	other threads:[~2008-01-27 17:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 11:52 [PATCH 0/12] mac80211/iwlwifi: A-MPDU Tx support Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 01/12] mac80211: A-MPDU Tx add session's and low level driver's API Ron Rindjunsky
2008-01-24  9:23   ` Johannes Berg
2008-01-27 17:24     ` Ron Rindjunsky [this message]
2008-01-21 11:52 ` [PATCH 02/12] mac80211: A-MPDU Tx add MLME structures Ron Rindjunsky
2008-01-24  9:29   ` Johannes Berg
2008-01-27 17:25     ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 03/12] mac80211: A-MPDU Tx adding basic functionality Ron Rindjunsky
2008-01-24  9:30   ` Johannes Berg
2008-01-27 17:25     ` Ron Rindjunsky
2008-01-24  9:34   ` Johannes Berg
2008-01-27 17:25     ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 04/12] mac80211: A-MPDU Tx MLME data initialization Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 05/12] mac80211: A-MPDU add debugfs support Ron Rindjunsky
2008-01-24  9:45   ` Johannes Berg
2008-01-21 11:52 ` [PATCH 06/12] mac80211: A-MPDU Tx adding qdisc support Ron Rindjunsky
2008-01-24  9:42   ` Johannes Berg
2008-01-27 17:26     ` Ron Rindjunsky
2008-01-29 16:12       ` Johannes Berg
2008-01-30  9:11         ` Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 07/12] mac80211: A-MPDU Tx change tx_status to support Block Ack data Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 08/12] mac80211: A-MPDU Tx add delBA from recipient support Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 09/12] iwlwifi: A-MPDU Tx conform API to mac80211 Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 10/12] iwlwifi: A-MPDU Tx conform flows " Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 11/12] iwlwifi: A-MPDU Tx conform block Ack rate scaling " Ron Rindjunsky
2008-01-21 11:52 ` [PATCH 12/12] wlwifi: A-MPDU Tx activation by load measures Ron Rindjunsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c85cb4470801270924n647e83f4s6ac56154ef36dee8@mail.gmail.com \
    --to=rindjon@googlemail.com \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox