From: Tomas Winkler <tomas.winkler@intel.com>
To: linville@tuxdriver.com, johannes@sipsolutions.net, yi.zhu@intel.com
Cc: linux-wireless@vger.kernel.org, Tomas Winkler <tomas.winkler@intel.com>
Subject: [PATCH 1/2] mac80211: fix unbalanced locking in ieee80211_get_buffered_bc
Date: Mon, 2 Jun 2008 18:44:11 +0300 [thread overview]
Message-ID: <1212421452-5635-1-git-send-email-tomas.winkler@intel.com> (raw)
This patch fixes unbalanced locking in ieee80211_get_buffered_bc
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
net/mac80211/tx.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 16af308..8a5b24d 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -2008,8 +2008,10 @@ ieee80211_get_buffered_bc(struct ieee80211_hw *hw,
break;
}
- if (WARN_ON(tx.skb != skb))
- return NULL;
+ if (WARN_ON(tx.skb != skb)) {
+ skb = NULL;
+ goto out;
+ }
if (res == TX_DROP) {
I802_DEBUG_INC(local->tx_handlers_drop);
--
1.5.4.1
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next reply other threads:[~2008-06-02 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 15:44 Tomas Winkler [this message]
2008-06-02 15:44 ` [PATCH 2/2] mac80211: removing shadowed sband Tomas Winkler
2008-06-02 16:54 ` Johannes Berg
2008-06-02 17:04 ` Tomas Winkler
2008-06-02 17:08 ` Johannes Berg
2008-06-02 16:53 ` [PATCH 1/2] mac80211: fix unbalanced locking in ieee80211_get_buffered_bc Johannes Berg
2008-06-02 16:59 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212421452-5635-1-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox