Re: [PATCH 2/2] mac80211: removing shadowed sband

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On Mon, 2008-06-02 at 20:04 +0300, Tomas Winkler wrote:
> On Mon, Jun 2, 2008 at 7:54 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Mon, 2008-06-02 at 18:44 +0300, Tomas Winkler wrote:
> >> This patch removes doubly defined sband variable
> >
> >>       if ((info->flags & IEEE80211_TX_CTL_USE_RTS_CTS) ||
> >>           (info->flags & IEEE80211_TX_CTL_USE_CTS_PROTECT)) {
> >> -             struct ieee80211_supported_band *sband;
> >>               struct ieee80211_rate *rate;
> >>               s8 baserate = -1;
> >>               int idx;
> >
> > I guess we can remove the double assignment too since it's the same as
> > already done. I must have added that when doing the mechanical tx rate
> > idx changes. :/
> >
> Good point. I also did only mechanical fix for the compiler warning ;)

Heh :) Was that sparse, or do you actually get compiler warnings?
Anyhow, here's my Acked-by: Johannes Berg <johannes@sipsolutions.net>,
feel free to add to the patches right away.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]