From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: fix unbalanced locking in ieee80211_get_buffered_bc
Date: Mon, 2 Jun 2008 19:59:42 +0300 [thread overview]
Message-ID: <1ba2fa240806020959x26a24c50sc728ab5534babd64@mail.gmail.com> (raw)
In-Reply-To: <1212425595.20021.0.camel@johannes.berg>
On Mon, Jun 2, 2008 at 7:53 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> Good catch. However, we'll leak skb in that case, so how about:
>
> if (WARN_ON(tx.skb != skb))
> - return NULL;
> + res = TX_DROP;
>
Looks better, will send V2.
> johannes
>
prev parent reply other threads:[~2008-06-02 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 15:44 [PATCH 1/2] mac80211: fix unbalanced locking in ieee80211_get_buffered_bc Tomas Winkler
2008-06-02 15:44 ` [PATCH 2/2] mac80211: removing shadowed sband Tomas Winkler
2008-06-02 16:54 ` Johannes Berg
2008-06-02 17:04 ` Tomas Winkler
2008-06-02 17:08 ` Johannes Berg
2008-06-02 16:53 ` [PATCH 1/2] mac80211: fix unbalanced locking in ieee80211_get_buffered_bc Johannes Berg
2008-06-02 16:59 ` Tomas Winkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240806020959x26a24c50sc728ab5534babd64@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox