public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ron Rindjunsky <ron.rindjunsky@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: [RFC] do not fragment while aggregation is in use
Date: Wed, 11 Jun 2008 23:25:26 +0200	[thread overview]
Message-ID: <1213219526.3827.0.camel@johannes.berg> (raw)
In-Reply-To: <1213207296-14548-1-git-send-email-ron.rindjunsky@intel.com>

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Thanks.

> -	/*
> -	 * Warn when submitting a fragmented A-MPDU frame and drop it.
> -	 * This is an error and needs to be fixed elsewhere, but when
> -	 * done needs to take care of monitor interfaces (injection)
> -	 * etc.
> -	 */
> -	if (WARN_ON(tx->flags & IEEE80211_TX_CTL_AMPDU ||
> -		    skb_get_queue_mapping(tx->skb) >=
> -			ieee80211_num_regular_queues(&tx->local->hw)))
> -		return TX_DROP;
> -

Should we keep that, just in case? If it ever happens and the hw rejects
a fragment for some reason, we'll otherwise clobber some state and
probably crash.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-06-11 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 18:01 [PATCH 1/1] mac80211: [RFC] do not fragment while aggregation is in use Ron Rindjunsky
2008-06-11 21:25 ` Johannes Berg [this message]
2008-06-12  9:56   ` [PATCH 1/1] mac80211: [RFC] do not fragment while aggregationis " Rindjunsky, Ron
2008-06-12 11:04     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213219526.3827.0.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ron.rindjunsky@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox