From: "Rindjunsky, Ron" <ron.rindjunsky@intel.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 1/1] mac80211: [RFC] do not fragment while aggregationis in use
Date: Thu, 12 Jun 2008 12:56:07 +0300 [thread overview]
Message-ID: <1879838866982C46A9CB3D56BA49ADEB050224AF@hasmsx411.ger.corp.intel.com> (raw)
In-Reply-To: <1213219526.3827.0.camel@johannes.berg>
>> - /*
>> - * Warn when submitting a fragmented A-MPDU frame and drop it.
>> - * This is an error and needs to be fixed elsewhere, but when
>> - * done needs to take care of monitor interfaces (injection)
>> - * etc.
>> - */
>> - if (WARN_ON(tx->flags & IEEE80211_TX_CTL_AMPDU ||
>> - skb_get_queue_mapping(tx->skb) >=
>> - ieee80211_num_regular_queues(&tx->local->hw)))
>> - return TX_DROP;
>> -
> Should we keep that, just in case? If it ever happens and the hw
rejects
> a fragment for some reason, we'll otherwise clobber some state and
> probably crash.
Agree. Should I resend the patch or would you just remove it from the
original patch?
> johannes
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2008-06-12 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 18:01 [PATCH 1/1] mac80211: [RFC] do not fragment while aggregation is in use Ron Rindjunsky
2008-06-11 21:25 ` Johannes Berg
2008-06-12 9:56 ` Rindjunsky, Ron [this message]
2008-06-12 11:04 ` [PATCH 1/1] mac80211: [RFC] do not fragment while aggregationis " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1879838866982C46A9CB3D56BA49ADEB050224AF@hasmsx411.ger.corp.intel.com \
--to=ron.rindjunsky@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox