From: Johannes Berg <johannes@sipsolutions.net>
To: "Rindjunsky, Ron" <ron.rindjunsky@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: RE: [PATCH 1/1] mac80211: [RFC] do not fragment while aggregationis in use
Date: Thu, 12 Jun 2008 13:04:12 +0200 [thread overview]
Message-ID: <1213268652.3936.0.camel@johannes.berg> (raw)
In-Reply-To: <1879838866982C46A9CB3D56BA49ADEB050224AF@hasmsx411.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Thu, 2008-06-12 at 12:56 +0300, Rindjunsky, Ron wrote:
> >> - /*
> >> - * Warn when submitting a fragmented A-MPDU frame and drop it.
> >> - * This is an error and needs to be fixed elsewhere, but when
> >> - * done needs to take care of monitor interfaces (injection)
> >> - * etc.
> >> - */
> >> - if (WARN_ON(tx->flags & IEEE80211_TX_CTL_AMPDU ||
> >> - skb_get_queue_mapping(tx->skb) >=
> >> - ieee80211_num_regular_queues(&tx->local->hw)))
> >> - return TX_DROP;
> >> -
>
> > Should we keep that, just in case? If it ever happens and the hw
> rejects
> > a fragment for some reason, we'll otherwise clobber some state and
> > probably crash.
>
> Agree. Should I resend the patch or would you just remove it from the
> original patch?
Well, you probably want to adjust the comment, since you did fix it
elsewhere :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-06-12 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 18:01 [PATCH 1/1] mac80211: [RFC] do not fragment while aggregation is in use Ron Rindjunsky
2008-06-11 21:25 ` Johannes Berg
2008-06-12 9:56 ` [PATCH 1/1] mac80211: [RFC] do not fragment while aggregationis " Rindjunsky, Ron
2008-06-12 11:04 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213268652.3936.0.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ron.rindjunsky@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox