From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com,
linux-wireless@vger.kernel.org,
Gregory Greenman <gregory.greenman@intel.com>
Subject: Re: [RFC PATCH] iwlwifi: Memory allocation optimization.
Date: Sat, 05 Jul 2008 18:30:35 +0200 [thread overview]
Message-ID: <1215275435.6848.12.camel@johannes.berg> (raw)
In-Reply-To: <1215103274-8516-1-git-send-email-tomas.winkler@intel.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Thu, 2008-07-03 at 19:41 +0300, Tomas Winkler wrote:
> From: Gregory Greenman <gregory.greenman@intel.com>
>
> This patch optimizes memory allocation. The cmd member of
> iwl_tx_queue was allocated previously as a continuous block
> of memory. This patch allocates separate memory chunks for each command
> and maps/unmaps these chunks in the run time.
You still allocate a lot of unused memory. Why don't you, at least
temporarily until you've figured out how to do gather-IO [1], reduce the
maximum number of DMA fragments to 2 so you need 1/10th the memory? You
can always bump it back up after you do the necessary mac80211 changes.
johannes
[1] and I still maintain that you will not be able to, but that's
irrelevant.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-07-05 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:41 [RFC PATCH] iwlwifi: Memory allocation optimization Tomas Winkler
2008-07-05 16:30 ` Johannes Berg [this message]
2008-07-05 18:44 ` Tomas Winkler
2008-07-05 18:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215275435.6848.12.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=gregory.greenman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox