Re: [RFC PATCH] iwlwifi: Memory allocation optimization.

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]


> We have to improve more places in allocation and we hopefully had
> mapped all of them.
> This patch fixes allocation that was in order 5 in( (ATOMCI | DMA) and
> was most urgent.
> The section you've suggested is I think on 3rd or 4th place. Don't
> worry we get there.
> What is more important now that we get some feedback on this fix.

Fair enough. I can't really comment on that patch. You might want to
have somebody do some spring cleaning in iwlwifi, I just found this
comment I inserted there during some refactoring:

4150c572 (Johannes Berg      2007-09-17 01:29:23 -0400 6941) /*
4150c572 (Johannes Berg      2007-09-17 01:29:23 -0400 6942)  * very dubious code was here; the probe filtering flag is never set:
4150c572 (Johannes Berg      2007-09-17 01:29:23 -0400 6943)  *
b481de9c (Zhu Yi             2007-09-25 17:54:57 -0700 6944)    if (unlikely(test_bit(STATUS_SCANNING, &priv->status)) &&
b481de9c (Zhu Yi             2007-09-25 17:54:57 -0700 6945)        !(priv->hw->flags & IEEE80211_HW_NO_PROBE_FILTERING)) {
4150c572 (Johannes Berg      2007-09-17 01:29:23 -0400 6946)  */

:)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]