Re: [RFC PATCH] iwlwifi: Memory allocation optimization.

["Tomas Winkler" <tomasw@gmail.com>]

On Sat, Jul 5, 2008 at 7:30 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2008-07-03 at 19:41 +0300, Tomas Winkler wrote:
>> From: Gregory Greenman <gregory.greenman@intel.com>
>>
>> This patch optimizes memory allocation. The cmd member of
>> iwl_tx_queue was allocated previously as a continuous block
>> of memory. This patch allocates separate memory chunks for each command
>> and maps/unmaps these chunks in the run time.
>
> You still allocate a lot of unused memory. Why don't you, at least
> temporarily until you've figured out how to do gather-IO [1], reduce the
> maximum number of DMA fragments to 2 so you need 1/10th the memory? You
> can always bump it back up after you do the necessary mac80211 changes.

We have to improve more places in allocation and we hopefully had
mapped all of them.
This patch fixes allocation that was in order 5 in( (ATOMCI | DMA) and
was most urgent.
The section you've suggested is I think on 3rd or 4th place. Don't
worry we get there.
What is more important now that we get some feedback on this fix.
Thanks
Tomas


> johannes
>
> [1] and I still maintain that you will not be able to, but that's
> irrelevant.
>